Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/common/extensions/chrome_manifest_url_handlers.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_CHROME_MANIFEST_URL_HANDLERS_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_CHROME_MANIFEST_URL_HANDLERS_H_
6 #define CHROME_COMMON_EXTENSIONS_CHROME_MANIFEST_URL_HANDLERS_H_ 6 #define CHROME_COMMON_EXTENSIONS_CHROME_MANIFEST_URL_HANDLERS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/common/extension.h" 10 #include "extensions/common/extension.h"
11 #include "extensions/common/manifest_handler.h" 11 #include "extensions/common/manifest_handler.h"
12 12
13 // Chrome-specific extension manifest URL handlers. 13 // Chrome-specific extension manifest URL handlers.
14 14
15 namespace base { 15 namespace base {
16 class DictionaryValue; 16 class DictionaryValue;
17 } 17 }
18 18
19 namespace extensions { 19 namespace extensions {
20 20
21 namespace chrome_manifest_urls { 21 namespace chrome_manifest_urls {
22 const GURL& GetDevToolsPage(const Extension* extension); 22 const GURL& GetDevToolsPage(const Extension* extension);
23 } 23 }
24 24
25 // Stores Chrome URL overrides specified in extensions manifests. 25 // Stores Chrome URL overrides specified in extensions manifests.
26 struct URLOverrides : public Extension::ManifestData { 26 struct URLOverrides : public Extension::ManifestData {
27 typedef std::map<const std::string, GURL> URLOverrideMap; 27 typedef std::map<const std::string, GURL> URLOverrideMap;
28 28
29 URLOverrides(); 29 URLOverrides();
30 virtual ~URLOverrides(); 30 ~URLOverrides() override;
31 31
32 static const URLOverrideMap& GetChromeURLOverrides( 32 static const URLOverrideMap& GetChromeURLOverrides(
33 const Extension* extension); 33 const Extension* extension);
34 34
35 // A map of chrome:// hostnames (newtab, downloads, etc.) to Extension URLs 35 // A map of chrome:// hostnames (newtab, downloads, etc.) to Extension URLs
36 // which override the handling of those URLs. (see ExtensionOverrideUI). 36 // which override the handling of those URLs. (see ExtensionOverrideUI).
37 URLOverrideMap chrome_url_overrides_; 37 URLOverrideMap chrome_url_overrides_;
38 }; 38 };
39 39
40 // Parses the "devtools_page" manifest key. 40 // Parses the "devtools_page" manifest key.
41 class DevToolsPageHandler : public ManifestHandler { 41 class DevToolsPageHandler : public ManifestHandler {
42 public: 42 public:
43 DevToolsPageHandler(); 43 DevToolsPageHandler();
44 virtual ~DevToolsPageHandler(); 44 ~DevToolsPageHandler() override;
45 45
46 virtual bool Parse(Extension* extension, base::string16* error) override; 46 bool Parse(Extension* extension, base::string16* error) override;
47 47
48 private: 48 private:
49 virtual const std::vector<std::string> Keys() const override; 49 const std::vector<std::string> Keys() const override;
50 50
51 DISALLOW_COPY_AND_ASSIGN(DevToolsPageHandler); 51 DISALLOW_COPY_AND_ASSIGN(DevToolsPageHandler);
52 }; 52 };
53 53
54 // Parses the "chrome_url_overrides" manifest key. 54 // Parses the "chrome_url_overrides" manifest key.
55 class URLOverridesHandler : public ManifestHandler { 55 class URLOverridesHandler : public ManifestHandler {
56 public: 56 public:
57 URLOverridesHandler(); 57 URLOverridesHandler();
58 virtual ~URLOverridesHandler(); 58 ~URLOverridesHandler() override;
59 59
60 virtual bool Parse(Extension* extension, base::string16* error) override; 60 bool Parse(Extension* extension, base::string16* error) override;
61 61
62 private: 62 private:
63 virtual const std::vector<std::string> Keys() const override; 63 const std::vector<std::string> Keys() const override;
64 64
65 DISALLOW_COPY_AND_ASSIGN(URLOverridesHandler); 65 DISALLOW_COPY_AND_ASSIGN(URLOverridesHandler);
66 }; 66 };
67 67
68 } // namespace extensions 68 } // namespace extensions
69 69
70 #endif // CHROME_COMMON_EXTENSIONS_CHROME_MANIFEST_URL_HANDLERS_H_ 70 #endif // CHROME_COMMON_EXTENSIONS_CHROME_MANIFEST_URL_HANDLERS_H_
OLDNEW
« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.h ('k') | chrome/common/extensions/features/chrome_channel_feature_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698