chrome/common/extensions/manifest_tests/chrome_manifest_test.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/chrome_manifest_test.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc ('k') | chrome/common/extensions/permissions/chrome_api_permissions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/chrome_manifest_test.h

diff --git a/chrome/common/extensions/manifest_tests/chrome_manifest_test.h b/chrome/common/extensions/manifest_tests/chrome_manifest_test.h

index 7a71cdd51637ad5003b1a366a7adcc12d2dba1aa..0de34d4fc9beb77bb59a0576435730fca96360f2 100644

--- a/chrome/common/extensions/manifest_tests/chrome_manifest_test.h

+++ b/chrome/common/extensions/manifest_tests/chrome_manifest_test.h

@@ -18,7 +18,7 @@ class ChromeManifestTest : public extensions::ManifestTest {

virtual ~ChromeManifestTest();

// ManifestTest overrides:

- virtual base::FilePath GetTestDataDir() override;

+ base::FilePath GetTestDataDir() override;

private:

// Force the manifest tests to run as though they are on trunk, since several