Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/common/extensions/api/commands/commands_handler.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_ 6 #define CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/common/extensions/command.h" 11 #include "chrome/common/extensions/command.h"
12 #include "extensions/common/extension.h" 12 #include "extensions/common/extension.h"
13 #include "extensions/common/manifest.h" 13 #include "extensions/common/manifest.h"
14 #include "extensions/common/manifest_handler.h" 14 #include "extensions/common/manifest_handler.h"
15 15
16 namespace extensions { 16 namespace extensions {
17 17
18 struct CommandsInfo : public Extension::ManifestData { 18 struct CommandsInfo : public Extension::ManifestData {
19 CommandsInfo(); 19 CommandsInfo();
20 virtual ~CommandsInfo(); 20 ~CommandsInfo() override;
21 21
22 // Optional list of commands (keyboard shortcuts). 22 // Optional list of commands (keyboard shortcuts).
23 // These commands are the commands which the extension wants to use, which are 23 // These commands are the commands which the extension wants to use, which are
24 // not necessarily the ones it can use, as it might be inactive (see also 24 // not necessarily the ones it can use, as it might be inactive (see also
25 // Get*Command[s] in CommandService). 25 // Get*Command[s] in CommandService).
26 scoped_ptr<Command> browser_action_command; 26 scoped_ptr<Command> browser_action_command;
27 scoped_ptr<Command> page_action_command; 27 scoped_ptr<Command> page_action_command;
28 CommandMap named_commands; 28 CommandMap named_commands;
29 29
30 static const Command* GetBrowserActionCommand(const Extension* extension); 30 static const Command* GetBrowserActionCommand(const Extension* extension);
31 static const Command* GetPageActionCommand(const Extension* extension); 31 static const Command* GetPageActionCommand(const Extension* extension);
32 static const CommandMap* GetNamedCommands(const Extension* extension); 32 static const CommandMap* GetNamedCommands(const Extension* extension);
33 }; 33 };
34 34
35 // Parses the "commands" manifest key. 35 // Parses the "commands" manifest key.
36 class CommandsHandler : public ManifestHandler { 36 class CommandsHandler : public ManifestHandler {
37 public: 37 public:
38 CommandsHandler(); 38 CommandsHandler();
39 virtual ~CommandsHandler(); 39 ~CommandsHandler() override;
40 40
41 virtual bool Parse(Extension* extension, base::string16* error) override; 41 bool Parse(Extension* extension, base::string16* error) override;
42 virtual bool AlwaysParseForType(Manifest::Type type) const override; 42 bool AlwaysParseForType(Manifest::Type type) const override;
43 43
44 private: 44 private:
45 // If the extension defines a browser action, but no command for it, then 45 // If the extension defines a browser action, but no command for it, then
46 // we synthesize a generic one, so the user can configure a shortcut for it. 46 // we synthesize a generic one, so the user can configure a shortcut for it.
47 // No keyboard shortcut will be assigned to it, until the user selects one. 47 // No keyboard shortcut will be assigned to it, until the user selects one.
48 void MaybeSetBrowserActionDefault(const Extension* extension, 48 void MaybeSetBrowserActionDefault(const Extension* extension,
49 CommandsInfo* info); 49 CommandsInfo* info);
50 50
51 virtual const std::vector<std::string> Keys() const override; 51 const std::vector<std::string> Keys() const override;
52 52
53 DISALLOW_COPY_AND_ASSIGN(CommandsHandler); 53 DISALLOW_COPY_AND_ASSIGN(CommandsHandler);
54 }; 54 };
55 55
56 } // namespace extensions 56 } // namespace extensions
57 57
58 #endif // CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_ 58 #endif // CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/common/chrome_content_client.h ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698