chrome/test/chromedriver/chrome/navigation_tracker.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc ('k') | chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/navigation_tracker.h

diff --git a/chrome/test/chromedriver/chrome/navigation_tracker.h b/chrome/test/chromedriver/chrome/navigation_tracker.h

index f309c59feb34d2c9e0bafea6436f9ee986f6331e..a75a094178026570a29aabd2c0bce8fa448bf4e3 100644

--- a/chrome/test/chromedriver/chrome/navigation_tracker.h

+++ b/chrome/test/chromedriver/chrome/navigation_tracker.h

@@ -37,19 +37,19 @@ class NavigationTracker : public DevToolsEventListener {

LoadingState known_state,

const BrowserInfo* browser_info);

- virtual ~NavigationTracker();

+ ~NavigationTracker() override;

// Gets whether a navigation is pending for the specified frame. |frame_id|

// may be empty to signify the main frame.

Status IsPendingNavigation(const std::string& frame_id, bool* is_pending);

// Overridden from DevToolsEventListener:

- virtual Status OnConnected(DevToolsClient* client) override;

- virtual Status OnEvent(DevToolsClient* client,

- const std::string& method,

- const base::DictionaryValue& params) override;

- virtual Status OnCommandSuccess(DevToolsClient* client,

- const std::string& method) override;

+ Status OnConnected(DevToolsClient* client) override;

+ Status OnEvent(DevToolsClient* client,

+ const std::string& method,

+ const base::DictionaryValue& params) override;

+ Status OnCommandSuccess(DevToolsClient* client,

+ const std::string& method) override;

private:

DevToolsClient* client_;