Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_UI_OVERRIDES_HANDLER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_UI_OVERRIDES_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_UI_OVERRIDES_HANDLER_H_ 6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_UI_OVERRIDES_HANDLER_H_
7 7
8 #include "chrome/common/extensions/api/manifest_types.h" 8 #include "chrome/common/extensions/api/manifest_types.h"
9 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
10 #include "extensions/common/manifest_handler.h" 10 #include "extensions/common/manifest_handler.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 class ManifestPermission; 14 class ManifestPermission;
15 15
16 // UIOverrides is associated with "chrome_ui_overrides" manifest key, and 16 // UIOverrides is associated with "chrome_ui_overrides" manifest key, and
17 // represents manifest settings to override aspects of the Chrome user 17 // represents manifest settings to override aspects of the Chrome user
18 // interface. 18 // interface.
19 struct UIOverrides : public Extension::ManifestData { 19 struct UIOverrides : public Extension::ManifestData {
20 UIOverrides(); 20 UIOverrides();
21 virtual ~UIOverrides(); 21 ~UIOverrides() override;
22 22
23 static const UIOverrides* Get(const Extension* extension); 23 static const UIOverrides* Get(const Extension* extension);
24 24
25 static bool RemovesBookmarkButton(const Extension* extension); 25 static bool RemovesBookmarkButton(const Extension* extension);
26 static bool RemovesBookmarkShortcut(const Extension* extension); 26 static bool RemovesBookmarkShortcut(const Extension* extension);
27 static bool RemovesBookmarkOpenPagesShortcut(const Extension* extension); 27 static bool RemovesBookmarkOpenPagesShortcut(const Extension* extension);
28 28
29 scoped_ptr<api::manifest_types::ChromeUIOverrides::Bookmarks_ui> bookmarks_ui; 29 scoped_ptr<api::manifest_types::ChromeUIOverrides::Bookmarks_ui> bookmarks_ui;
30 30
31 scoped_ptr<ManifestPermission> manifest_permission; 31 scoped_ptr<ManifestPermission> manifest_permission;
32 32
33 private: 33 private:
34 DISALLOW_COPY_AND_ASSIGN(UIOverrides); 34 DISALLOW_COPY_AND_ASSIGN(UIOverrides);
35 }; 35 };
36 36
37 class UIOverridesHandler : public ManifestHandler { 37 class UIOverridesHandler : public ManifestHandler {
38 public: 38 public:
39 UIOverridesHandler(); 39 UIOverridesHandler();
40 virtual ~UIOverridesHandler(); 40 ~UIOverridesHandler() override;
41 41
42 virtual bool Parse(Extension* extension, base::string16* error) override; 42 bool Parse(Extension* extension, base::string16* error) override;
43 virtual bool Validate(const Extension* extension, 43 bool Validate(const Extension* extension,
44 std::string* error, 44 std::string* error,
45 std::vector<InstallWarning>* warnings) const override; 45 std::vector<InstallWarning>* warnings) const override;
46 46
47 virtual ManifestPermission* CreatePermission() override; 47 ManifestPermission* CreatePermission() override;
48 virtual ManifestPermission* CreateInitialRequiredPermission( 48 ManifestPermission* CreateInitialRequiredPermission(
49 const Extension* extension) override; 49 const Extension* extension) override;
50 50
51 private: 51 private:
52 class ManifestPermissionImpl; 52 class ManifestPermissionImpl;
53 53
54 virtual const std::vector<std::string> Keys() const override; 54 const std::vector<std::string> Keys() const override;
55 55
56 DISALLOW_COPY_AND_ASSIGN(UIOverridesHandler); 56 DISALLOW_COPY_AND_ASSIGN(UIOverridesHandler);
57 }; 57 };
58 58
59 } // namespace extensions 59 } // namespace extensions
60 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_UI_OVERRIDES_HANDLER_H_ 60 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_UI_OVERRIDES_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698