chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/heap_snapshot_taker.h ('k') | chrome/test/chromedriver/chrome/javascript_dialog_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc b/chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc

index 2b3aa97ddbc07f7f054fbc4049622680f4c8969e..342ae8f28e190933c0e2ae8814c795951a9d2fe3 100644

--- a/chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc

+++ b/chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc

@@ -30,7 +30,7 @@ class DummyDevToolsClient : public StubDevToolsClient {

error_after_events_(error_after_events),

uid_(1),

disabled_(false) {}

- virtual ~DummyDevToolsClient() {}

+ ~DummyDevToolsClient() override {}

bool IsDisabled() { return disabled_; }

@@ -48,8 +48,8 @@ class DummyDevToolsClient : public StubDevToolsClient {

}

// Overridden from DevToolsClient:

- virtual Status SendCommand(const std::string& method,

- const base::DictionaryValue& params) override {

+ Status SendCommand(const std::string& method,

+ const base::DictionaryValue& params) override {

if (!disabled_)

disabled_ = method == "Debugger.disable";

if (method == method_ && !error_after_events_)