Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3451)

Unified Diff: chrome/service/cloud_print/cloud_print_proxy.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_proxy.h
diff --git a/chrome/service/cloud_print/cloud_print_proxy.h b/chrome/service/cloud_print/cloud_print_proxy.h
index 7f839d1806cbe84d9ec70e65a7857f38855d96a1..4f7daa065c407b864c379b88f683b6fc204bd778 100644
--- a/chrome/service/cloud_print/cloud_print_proxy.h
+++ b/chrome/service/cloud_print/cloud_print_proxy.h
@@ -34,7 +34,7 @@ class CloudPrintProxy : public CloudPrintProxyFrontend,
virtual void OnCloudPrintProxyDisabled(bool persist_state) {}
};
CloudPrintProxy();
- virtual ~CloudPrintProxy();
+ ~CloudPrintProxy() override;
// Initializes the object. This should be called every time an object of this
// class is constructed.
@@ -62,18 +62,17 @@ class CloudPrintProxy : public CloudPrintProxyFrontend,
}
// CloudPrintProxyFrontend implementation. Called on UI thread.
- virtual void OnAuthenticated(const std::string& robot_oauth_refresh_token,
- const std::string& robot_email,
- const std::string& user_email) override;
- virtual void OnAuthenticationFailed() override;
- virtual void OnPrintSystemUnavailable() override;
- virtual void OnUnregisterPrinters(
- const std::string& auth_token,
- const std::list<std::string>& printer_ids) override;
- virtual void OnXmppPingUpdated(int ping_timeout) override;
+ void OnAuthenticated(const std::string& robot_oauth_refresh_token,
+ const std::string& robot_email,
+ const std::string& user_email) override;
+ void OnAuthenticationFailed() override;
+ void OnPrintSystemUnavailable() override;
+ void OnUnregisterPrinters(const std::string& auth_token,
+ const std::list<std::string>& printer_ids) override;
+ void OnXmppPingUpdated(int ping_timeout) override;
// CloudPrintWipeout::Client implementation.
- virtual void OnUnregisterPrintersComplete() override;
+ void OnUnregisterPrintersComplete() override;
protected:
void ShutdownBackend();
« no previous file with comments | « chrome/service/cloud_print/cloud_print_connector.h ('k') | chrome/service/cloud_print/cloud_print_proxy_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698