chrome/test/chromedriver/chrome/stub_chrome.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/stub_chrome.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc ('k') | chrome/test/chromedriver/chrome/stub_devtools_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/stub_chrome.h

diff --git a/chrome/test/chromedriver/chrome/stub_chrome.h b/chrome/test/chromedriver/chrome/stub_chrome.h

index 130c1a58e1dd1318885dd467014aa3807b6d27d0..c0b1cb97384a41383e75bac9bd933b0f6e22d561 100644

--- a/chrome/test/chromedriver/chrome/stub_chrome.h

+++ b/chrome/test/chromedriver/chrome/stub_chrome.h

@@ -18,20 +18,19 @@ class WebView;

class StubChrome : public Chrome {

public:

StubChrome();

- virtual ~StubChrome();

+ ~StubChrome() override;

// Overridden from Chrome:

- virtual ChromeDesktopImpl* GetAsDesktop() override;

- virtual const BrowserInfo* GetBrowserInfo() override;

- virtual bool HasCrashedWebView() override;

- virtual Status GetWebViewIds(std::list<std::string>* web_view_ids) override;

- virtual Status GetWebViewById(const std::string& id,

- WebView** web_view) override;

- virtual Status CloseWebView(const std::string& id) override;

- virtual Status ActivateWebView(const std::string& id) override;

- virtual std::string GetOperatingSystemName() override;

- virtual bool IsMobileEmulationEnabled() const override;

- virtual Status Quit() override;

+ ChromeDesktopImpl* GetAsDesktop() override;

+ const BrowserInfo* GetBrowserInfo() override;

+ bool HasCrashedWebView() override;

+ Status GetWebViewIds(std::list<std::string>* web_view_ids) override;

+ Status GetWebViewById(const std::string& id, WebView** web_view) override;

+ Status CloseWebView(const std::string& id) override;

+ Status ActivateWebView(const std::string& id) override;

+ std::string GetOperatingSystemName() override;

+ bool IsMobileEmulationEnabled() const override;

+ Status Quit() override;

private:

BrowserInfo browser_info_;