chrome/test/chromedriver/chrome/javascript_dialog_manager.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/javascript_dialog_manager.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc ('k') | chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/javascript_dialog_manager.h

diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager.h b/chrome/test/chromedriver/chrome/javascript_dialog_manager.h

index fd8b8067b9581a67ebcb5a4165f4e3f6f2b5cf93..ffab9ba37d4d7013d7c90120ee017eb288562303 100644

--- a/chrome/test/chromedriver/chrome/javascript_dialog_manager.h

+++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager.h

@@ -23,7 +23,7 @@ class Status;

class JavaScriptDialogManager : public DevToolsEventListener {

public:

explicit JavaScriptDialogManager(DevToolsClient* client);

- virtual ~JavaScriptDialogManager();

+ ~JavaScriptDialogManager() override;

bool IsDialogOpen();

@@ -32,10 +32,10 @@ class JavaScriptDialogManager : public DevToolsEventListener {

Status HandleDialog(bool accept, const std::string* text);

// Overridden from DevToolsEventListener:

- virtual Status OnConnected(DevToolsClient* client) override;

- virtual Status OnEvent(DevToolsClient* client,

- const std::string& method,

- const base::DictionaryValue& params) override;

+ Status OnConnected(DevToolsClient* client) override;

+ Status OnEvent(DevToolsClient* client,

+ const std::string& method,

+ const base::DictionaryValue& params) override;

private:

DevToolsClient* client_;