Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h
index 22ecd91d5e57fafde6de5d9275e759f878a27d0c..93bb97f72ae1d5fcf5d70ee1d190f7c8990f4e7a 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_impl.h
@@ -27,19 +27,18 @@ class WebViewImpl;
class ChromeImpl : public Chrome {
public:
- virtual ~ChromeImpl();
+ ~ChromeImpl() override;
// Overridden from Chrome:
- virtual ChromeDesktopImpl* GetAsDesktop() override;
- virtual const BrowserInfo* GetBrowserInfo() override;
- virtual bool HasCrashedWebView() override;
- virtual Status GetWebViewIds(std::list<std::string>* web_view_ids) override;
- virtual Status GetWebViewById(const std::string& id,
- WebView** web_view) override;
- virtual Status CloseWebView(const std::string& id) override;
- virtual Status ActivateWebView(const std::string& id) override;
- virtual bool IsMobileEmulationEnabled() const override;
- virtual Status Quit() override;
+ ChromeDesktopImpl* GetAsDesktop() override;
+ const BrowserInfo* GetBrowserInfo() override;
+ bool HasCrashedWebView() override;
+ Status GetWebViewIds(std::list<std::string>* web_view_ids) override;
+ Status GetWebViewById(const std::string& id, WebView** web_view) override;
+ Status CloseWebView(const std::string& id) override;
+ Status ActivateWebView(const std::string& id) override;
+ bool IsMobileEmulationEnabled() const override;
+ Status Quit() override;
protected:
ChromeImpl(
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_remote_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698