Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc
index 99666726560ad19a3d29d640aa6cad509fed6f69..69ca375690d5146a77a7c76862cee9b8099caf40 100644
--- a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc
+++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc
@@ -27,10 +27,10 @@ namespace {
class RecorderDevToolsClient : public StubDevToolsClient {
public:
RecorderDevToolsClient() {}
- virtual ~RecorderDevToolsClient() {}
+ ~RecorderDevToolsClient() override {}
// Overridden from StubDevToolsClient:
- virtual Status SendCommandAndGetResult(
+ Status SendCommandAndGetResult(
const std::string& method,
const base::DictionaryValue& params,
scoped_ptr<base::DictionaryValue>* result) override {
@@ -99,14 +99,14 @@ namespace {
class FakeDevToolsClient : public StubDevToolsClient {
public:
FakeDevToolsClient() : listener_(NULL), closing_count_(0) {}
- virtual ~FakeDevToolsClient() {}
+ ~FakeDevToolsClient() override {}
void set_closing_count(int closing_count) {
closing_count_ = closing_count;
}
// Overridden from StubDevToolsClient:
- virtual Status SendCommandAndGetResult(
+ Status SendCommandAndGetResult(
const std::string& method,
const base::DictionaryValue& params,
scoped_ptr<base::DictionaryValue>* result) override {
@@ -120,7 +120,7 @@ class FakeDevToolsClient : public StubDevToolsClient {
}
return Status(kOk);
}
- virtual void AddListener(DevToolsEventListener* listener) override {
+ void AddListener(DevToolsEventListener* listener) override {
listener_ = listener;
}

Powered by Google App Engine
This is Rietveld 408576698