chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/geolocation_override_manager.h ('k') | chrome/test/chromedriver/chrome/heap_snapshot_taker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc b/chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc

index 0785476ef40cecf214f067cbed90bb740ef56cb7..955ced76f96e52d48e2511e00f2b37d39c70825d 100644

--- a/chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc

+++ b/chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc

@@ -39,10 +39,10 @@ struct Command {

class RecorderDevToolsClient : public StubDevToolsClient {

public:

RecorderDevToolsClient() {}

- virtual ~RecorderDevToolsClient() {}

+ ~RecorderDevToolsClient() override {}

// Overridden from StubDevToolsClient:

- virtual Status SendCommandAndGetResult(

+ Status SendCommandAndGetResult(

const std::string& method,

const base::DictionaryValue& params,

scoped_ptr<base::DictionaryValue>* result) override {