Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2163253003: Moves ash/strings to ash/common/strings (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook, reveman
CC:
arv+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, derat+watch_chromium.org, kalyank, oshima+watch_chromium.org, sadrul, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves ash/strings to ash/common/strings BUG=626869 TEST=none R=jamescook@chromium.org,reveman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798 Cr-Commit-Position: refs/heads/master@{#406746}

Patch Set 1 #

Patch Set 2 : extraneous #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13262 lines) Patch
M ash/BUILD.gn View 1 5 chunks +5 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_strings.grd View 1 1 chunk +52 lines, -52 lines 0 comments Download
M ash/ash_strings.gyp View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/strings/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/strings/ash_strings_am.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ar.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_bg.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_bn.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ca.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_cs.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_da.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_de.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_el.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_en-GB.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_es.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_es-419.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_et.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_fa.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_fi.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_fil.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_fr.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_gu.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_hi.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_hr.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_hu.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_id.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_it.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_iw.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ja.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_kn.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ko.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_lt.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_lv.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ml.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_mr.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ms.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_nl.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_no.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_pl.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_pt-BR.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_pt-PT.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ro.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ru.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_sk.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_sl.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_sr.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_sv.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_sw.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_ta.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_te.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_th.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_tr.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_uk.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_vi.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_zh-CN.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/strings/ash_strings_zh-TW.xtb View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/mus/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
D ash/strings/BUILD.gn View 1 1 chunk +0 lines, -105 lines 0 comments Download
D ash/strings/ash_strings_am.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_ar.xtb View 1 1 chunk +0 lines, -250 lines 0 comments Download
D ash/strings/ash_strings_bg.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_bn.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_ca.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_cs.xtb View 1 1 chunk +0 lines, -250 lines 0 comments Download
D ash/strings/ash_strings_da.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_de.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_el.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_en-GB.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_es.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_es-419.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_et.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_fa.xtb View 1 1 chunk +0 lines, -251 lines 0 comments Download
D ash/strings/ash_strings_fi.xtb View 1 1 chunk +0 lines, -250 lines 0 comments Download
D ash/strings/ash_strings_fil.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_fr.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_gu.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_hi.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_hr.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_hu.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_id.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_it.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_iw.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_ja.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_kn.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_ko.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_lt.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_lv.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_ml.xtb View 1 1 chunk +0 lines, -251 lines 0 comments Download
D ash/strings/ash_strings_mr.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_ms.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_nl.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_no.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_pl.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_pt-BR.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_pt-PT.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_ro.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_ru.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_sk.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_sl.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_sr.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_sv.xtb View 1 1 chunk +0 lines, -251 lines 0 comments Download
D ash/strings/ash_strings_sw.xtb View 1 1 chunk +0 lines, -252 lines 0 comments Download
D ash/strings/ash_strings_ta.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_te.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_th.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_tr.xtb View 1 1 chunk +0 lines, -254 lines 0 comments Download
D ash/strings/ash_strings_uk.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_vi.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_zh-CN.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
D ash/strings/ash_strings_zh-TW.xtb View 1 1 chunk +0 lines, -253 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/shutdown_policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/repack_locales.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/exo/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
sky
reveman: exo james: the rest (sorry).
4 years, 5 months ago (2016-07-20 23:19:35 UTC) #4
reveman
components/exo lgtm
4 years, 5 months ago (2016-07-20 23:32:58 UTC) #7
James Cook
LGTM
4 years, 5 months ago (2016-07-21 00:59:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163253003/10001
4 years, 5 months ago (2016-07-21 02:51:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 5 months ago (2016-07-21 03:06:33 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:08:30 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798
Cr-Commit-Position: refs/heads/master@{#406746}

Powered by Google App Engine
This is Rietveld 408576698