Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2081583002: Migrating majority of gamepad from content/browser/ to device/ (Closed)

Created:
4 years, 6 months ago by bajones
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrating majority of gamepad from content/browser/ to device/ BUG=612330 Committed: https://crrev.com/b9bb4c42d6b19a7d7131af942d3769c54e89981c Cr-Commit-Position: refs/heads/master@{#403998}

Patch Set 1 #

Patch Set 2 : Updates for Mac #

Patch Set 3 : More Mac fixes and test updates #

Patch Set 4 : Updated for Linux. Android WIP. #

Patch Set 5 : Fixed Android and Unit tests #

Total comments: 17

Patch Set 6 : Addressed feedback #

Patch Set 7 : Fixed missing GN dependency #

Patch Set 8 : The 2- no the 3 dependencies of gamepad are... wait, I'll come in again. #

Patch Set 9 : Various build fixes #

Patch Set 10 : And even more build fixes #

Patch Set 11 : Augh! #

Patch Set 12 : Depend on ALL the dependencies! #

Patch Set 13 : Oh FFS. I can spell. #

Patch Set 14 : Next attempt #

Total comments: 1

Patch Set 15 : Attempts at remaining platform fixes #

Total comments: 6

Patch Set 16 : Final tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1158 lines, -7515 lines) Patch
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +1 line, -8 lines 0 comments Download
M content/browser/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 2 3 4 5 2 chunks +0 lines, -3 lines 0 comments Download
D content/browser/gamepad/gamepad_consumer.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/browser/gamepad/gamepad_data_fetcher.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/browser/gamepad/gamepad_data_fetcher.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_android.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_android.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_linux.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_mac.h View 1 chunk +0 lines, -106 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm View 1 chunk +0 lines, -575 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_win.h View 1 chunk +0 lines, -97 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_win.cc View 1 chunk +0 lines, -352 lines 0 comments Download
D content/browser/gamepad/gamepad_provider.h View 1 chunk +0 lines, -168 lines 0 comments Download
D content/browser/gamepad/gamepad_provider.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D content/browser/gamepad/gamepad_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -163 lines 0 comments Download
M content/browser/gamepad/gamepad_service.h View 1 2 3 4 4 chunks +21 lines, -13 lines 0 comments Download
M content/browser/gamepad/gamepad_service.cc View 1 2 3 4 5 6 chunks +28 lines, -9 lines 0 comments Download
A content/browser/gamepad/gamepad_service_test_helpers.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +38 lines, -0 lines 0 comments Download
A content/browser/gamepad/gamepad_service_test_helpers.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_service_unittest.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
A content/browser/gamepad/gamepad_shared_buffer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +35 lines, -0 lines 0 comments Download
A content/browser/gamepad/gamepad_shared_buffer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +46 lines, -0 lines 0 comments Download
D content/browser/gamepad/gamepad_standard_mappings.h View 1 chunk +0 lines, -76 lines 0 comments Download
D content/browser/gamepad/gamepad_standard_mappings.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/gamepad/gamepad_standard_mappings_linux.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D content/browser/gamepad/gamepad_standard_mappings_mac.mm View 1 chunk +0 lines, -396 lines 0 comments Download
D content/browser/gamepad/gamepad_standard_mappings_win.cc View 1 chunk +0 lines, -269 lines 0 comments Download
D content/browser/gamepad/gamepad_test_helpers.h View 1 chunk +0 lines, -91 lines 0 comments Download
D content/browser/gamepad/gamepad_test_helpers.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/gamepad/raw_input_data_fetcher_win.h View 1 chunk +0 lines, -144 lines 0 comments Download
D content/browser/gamepad/raw_input_data_fetcher_win.cc View 1 chunk +0 lines, -532 lines 0 comments Download
D content/browser/gamepad/xbox_data_fetcher_mac.h View 1 chunk +0 lines, -190 lines 0 comments Download
D content/browser/gamepad/xbox_data_fetcher_mac.cc View 1 chunk +0 lines, -809 lines 0 comments Download
M content/browser/renderer_host/gamepad_browser_message_filter.h View 1 chunk +8 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_gamepad_host.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -2 lines 0 comments Download
D content/common/gamepad_user_gesture.h View 1 chunk +0 lines, -20 lines 0 comments Download
D content/common/gamepad_user_gesture.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +3 lines, -37 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +4 lines, -3 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +1 line, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +1 line, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/GamepadDevice.java View 1 2 3 1 chunk +0 lines, -183 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/GamepadList.java View 1 2 3 1 chunk +0 lines, -327 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/GamepadMappings.java View 1 2 3 1 chunk +0 lines, -254 lines 0 comments Download
D content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -309 lines 0 comments Download
M content/renderer/gamepad_shared_memory_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M device/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +13 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -0 lines 0 comments Download
A device/gamepad/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +116 lines, -0 lines 0 comments Download
A device/gamepad/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + device/gamepad/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadDevice.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadList.java View 1 2 3 4 5 6 chunks +6 lines, -8 lines 0 comments Download
A + device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadMappings.java View 1 2 3 6 chunks +12 lines, -13 lines 0 comments Download
A + device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java View 1 2 3 4 5 6 7 8 9 2 chunks +1 line, -2 lines 0 comments Download
A device/gamepad/gamepad.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +76 lines, -0 lines 0 comments Download
A device/gamepad/gamepad_consumer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +26 lines, -0 lines 0 comments Download
A + device/gamepad/gamepad_consumer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +13 lines, -15 lines 0 comments Download
A + device/gamepad/gamepad_data_fetcher.h View 1 2 3 3 chunks +12 lines, -10 lines 0 comments Download
A + device/gamepad/gamepad_data_fetcher.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
A device/gamepad/gamepad_export.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher.cc View 1 chunk +4 lines, -5 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_android.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_android.cc View 4 chunks +7 lines, -10 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_linux.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_linux.cc View 1 2 3 11 chunks +32 lines, -40 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_mac.h View 4 chunks +7 lines, -8 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_mac.mm View 1 2 13 chunks +67 lines, -88 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_win.h View 1 5 chunks +18 lines, -16 lines 0 comments Download
A + device/gamepad/gamepad_platform_data_fetcher_win.cc View 12 chunks +44 lines, -38 lines 0 comments Download
A + device/gamepad/gamepad_provider.h View 1 2 3 4 5 6 chunks +27 lines, -20 lines 0 comments Download
A + device/gamepad/gamepad_provider.cc View 1 2 3 4 11 chunks +42 lines, -65 lines 0 comments Download
A + device/gamepad/gamepad_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +20 lines, -35 lines 0 comments Download
A device/gamepad/gamepad_shared_buffer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +27 lines, -0 lines 0 comments Download
A + device/gamepad/gamepad_standard_mappings.h View 1 2 3 4 5 4 chunks +11 lines, -11 lines 0 comments Download
A + device/gamepad/gamepad_standard_mappings.cc View 2 chunks +8 lines, -11 lines 0 comments Download
A + device/gamepad/gamepad_standard_mappings_linux.cc View 1 2 4 chunks +25 lines, -26 lines 0 comments Download
A + device/gamepad/gamepad_standard_mappings_mac.mm View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + device/gamepad/gamepad_standard_mappings_win.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + device/gamepad/gamepad_test_helpers.h View 1 2 3 4 4 chunks +23 lines, -26 lines 0 comments Download
A + device/gamepad/gamepad_test_helpers.cc View 1 2 3 4 3 chunks +23 lines, -17 lines 0 comments Download
A + device/gamepad/gamepad_user_gesture.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + device/gamepad/gamepad_user_gesture.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + device/gamepad/raw_input_data_fetcher_win.h View 1 6 chunks +46 lines, -31 lines 0 comments Download
A + device/gamepad/raw_input_data_fetcher_win.cc View 1 2 27 chunks +53 lines, -68 lines 0 comments Download
A + device/gamepad/xbox_data_fetcher_mac.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + device/gamepad/xbox_data_fetcher_mac.cc View 1 2 22 chunks +82 lines, -126 lines 0 comments Download

Messages

Total messages: 78 (27 generated)
bajones
piman@: Please review changes in content/ (mostly removals) rockot@: Please review changes in device/ (mostly ...
4 years, 6 months ago (2016-06-22 22:25:07 UTC) #2
piman
https://codereview.chromium.org/2081583002/diff/80001/content/browser/gamepad/gamepad_service.cc File content/browser/gamepad/gamepad_service.cc (right): https://codereview.chromium.org/2081583002/diff/80001/content/browser/gamepad/gamepad_service.cc#newcode34 content/browser/gamepad/gamepad_service.cc:34: std::unique_ptr<device::GamepadSharedBuffer>( nit: base::MakeUnique<GamepadSharedBufferImpl>() should work (the unique_ptr should upcast ...
4 years, 6 months ago (2016-06-22 22:53:00 UTC) #3
jam
I'm added as a reviewer but you didn't mention any files for me to look ...
4 years, 6 months ago (2016-06-22 23:07:02 UTC) #4
bajones
Thanks for the feedback! Working on fixes now with one follow up question. On 2016/06/22 ...
4 years, 6 months ago (2016-06-22 23:16:37 UTC) #5
bajones
On 2016/06/22 23:07:02, jam wrote: > I'm added as a reviewer but you didn't mention ...
4 years, 6 months ago (2016-06-22 23:20:52 UTC) #6
piman
On 2016/06/22 23:16:37, bajones wrote: > Thanks for the feedback! Working on fixes now with ...
4 years, 6 months ago (2016-06-22 23:21:13 UTC) #7
bajones
On 2016/06/22 23:21:13, piman wrote: > I think the following should work: > new (shared_memory_.memory()) ...
4 years, 6 months ago (2016-06-23 01:50:05 UTC) #8
Ken Rockot(use gerrit already)
All seems fairly reasonable to me. One concern I have though (sorry!): now that //components ...
4 years, 6 months ago (2016-06-23 02:17:04 UTC) #9
bajones
On 2016/06/23 02:17:04, Ken Rockot wrote: > All seems fairly reasonable to me. One concern ...
4 years, 6 months ago (2016-06-23 03:25:46 UTC) #10
jam
On 2016/06/23 03:25:46, bajones wrote: > On 2016/06/23 02:17:04, Ken Rockot wrote: > > All ...
4 years, 6 months ago (2016-06-23 16:05:42 UTC) #11
Ken Rockot(use gerrit already)
On 2016/06/23 at 16:05:42, jam wrote: > On 2016/06/23 03:25:46, bajones wrote: > > On ...
4 years, 6 months ago (2016-06-23 16:20:46 UTC) #12
bajones
Since it seems like there's still some question about where these things should be located ...
4 years, 6 months ago (2016-06-23 16:29:56 UTC) #13
Ken Rockot(use gerrit already)
SGTM, agreed it's not worth blocking on that discussion. If it can move once it ...
4 years, 6 months ago (2016-06-23 16:31:09 UTC) #14
scottmg
https://codereview.chromium.org/2081583002/diff/80001/content/browser/gamepad/gamepad_shared_buffer_impl.h File content/browser/gamepad/gamepad_shared_buffer_impl.h (right): https://codereview.chromium.org/2081583002/diff/80001/content/browser/gamepad/gamepad_shared_buffer_impl.h#newcode5 content/browser/gamepad/gamepad_shared_buffer_impl.h:5: #ifndef CONTENT_COMMON_GAMEPAD_SHARED_BUFFER_IMPL_H_ This doesn't match the filename. https://codereview.chromium.org/2081583002/diff/80001/device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadList.java File ...
4 years, 6 months ago (2016-06-23 17:27:19 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081583002/100001
4 years, 6 months ago (2016-06-23 19:10:34 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/180798)
4 years, 6 months ago (2016-06-23 19:15:33 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081583002/120001
4 years, 6 months ago (2016-06-23 21:29:26 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/86244) android_clang_dbg_recipe on ...
4 years, 6 months ago (2016-06-23 21:35:48 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081583002/140001
4 years, 6 months ago (2016-06-23 22:39:44 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/180963)
4 years, 6 months ago (2016-06-23 22:48:49 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/180001
4 years, 6 months ago (2016-06-24 19:05:55 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/200001
4 years, 6 months ago (2016-06-24 19:18:22 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/224572)
4 years, 6 months ago (2016-06-24 19:41:23 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/220001
4 years, 6 months ago (2016-06-24 22:51:14 UTC) #35
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/191626)
4 years, 6 months ago (2016-06-24 23:00:45 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/240001
4 years, 6 months ago (2016-06-24 23:45:14 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/224772)
4 years, 6 months ago (2016-06-25 00:02:24 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/260001
4 years, 5 months ago (2016-06-29 22:38:52 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/227249)
4 years, 5 months ago (2016-06-29 23:06:19 UTC) #45
bajones
Alright, I'm pretty thoroughly stuck on this one now. I haven't been able to repro ...
4 years, 5 months ago (2016-06-30 22:55:04 UTC) #46
piman
On 2016/06/30 22:55:04, bajones wrote: > Alright, I'm pretty thoroughly stuck on this one now. ...
4 years, 5 months ago (2016-06-30 23:22:33 UTC) #47
denniskempin
On 2016/06/30 23:22:33, piman OOO back 2016-7-6 wrote: > On 2016/06/30 22:55:04, bajones wrote: > ...
4 years, 5 months ago (2016-07-01 17:26:55 UTC) #48
denniskempin
On 2016/07/01 17:26:55, denniskempin wrote: > On 2016/06/30 23:22:33, piman OOO back 2016-7-6 wrote: > ...
4 years, 5 months ago (2016-07-01 17:29:46 UTC) #49
Robert Sesek
https://codereview.chromium.org/2081583002/diff/260001/device/gamepad/BUILD.gn File device/gamepad/BUILD.gn (right): https://codereview.chromium.org/2081583002/diff/260001/device/gamepad/BUILD.gn#newcode65 device/gamepad/BUILD.gn:65: } To fix the Mac errors, you need: if ...
4 years, 5 months ago (2016-07-01 17:40:18 UTC) #51
bajones
Thanks for the assistance everyone! Trying out the updated patch now!
4 years, 5 months ago (2016-07-01 18:20:03 UTC) #52
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/280001
4 years, 5 months ago (2016-07-01 18:20:41 UTC) #54
bajones
Looks like this version is gonna actually pass the CQ dry run, so can I ...
4 years, 5 months ago (2016-07-01 19:30:42 UTC) #55
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 19:32:50 UTC) #57
scottmg
lgtm https://codereview.chromium.org/2081583002/diff/280001/content/browser/gamepad/gamepad_service_test_helpers.h File content/browser/gamepad/gamepad_service_test_helpers.h (right): https://codereview.chromium.org/2081583002/diff/280001/content/browser/gamepad/gamepad_service_test_helpers.h#newcode5 content/browser/gamepad/gamepad_service_test_helpers.h:5: #ifndef CONTENT_BROWSER_GAMEPAD_GAMEPAD_TEST_HELPERS_H_ Match up the guard with the ...
4 years, 5 months ago (2016-07-01 22:25:39 UTC) #58
bajones
On 2016/07/01 22:25:39, scottmg (OOO until August) wrote: Thanks! Done, done, and done.
4 years, 5 months ago (2016-07-01 22:39:11 UTC) #59
bajones
rockot@: Could I get a follow up review on device/? jochen@: Since it seems that ...
4 years, 5 months ago (2016-07-01 22:49:55 UTC) #61
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/2081583002/diff/280001/content/browser/gamepad/gamepad_shared_buffer_impl.h File content/browser/gamepad/gamepad_shared_buffer_impl.h (right): https://codereview.chromium.org/2081583002/diff/280001/content/browser/gamepad/gamepad_shared_buffer_impl.h#newcode29 content/browser/gamepad/gamepad_shared_buffer_impl.h:29: }; disallow copy/assign
4 years, 5 months ago (2016-07-05 13:49:07 UTC) #62
Ken Rockot(use gerrit already)
Sorry for the delay - device lgtm
4 years, 5 months ago (2016-07-05 13:59:42 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/300001
4 years, 5 months ago (2016-07-06 16:59:33 UTC) #66
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99082)
4 years, 5 months ago (2016-07-06 18:55:50 UTC) #68
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/300001
4 years, 5 months ago (2016-07-06 18:59:15 UTC) #70
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99279)
4 years, 5 months ago (2016-07-06 22:50:36 UTC) #72
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081583002/300001
4 years, 5 months ago (2016-07-06 23:07:12 UTC) #74
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 5 months ago (2016-07-07 00:11:25 UTC) #75
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:11:45 UTC) #76
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:13:15 UTC) #78
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/b9bb4c42d6b19a7d7131af942d3769c54e89981c
Cr-Commit-Position: refs/heads/master@{#403998}

Powered by Google App Engine
This is Rietveld 408576698