device/gamepad/gamepad_shared_buffer.h - Issue 2081583002: Migrating majority of gamepad from content/browser/ to device/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/gamepad/gamepad_shared_buffer.h

Issue 2081583002: Migrating majority of gamepad from content/browser/ to device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android and Unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/gamepad/gamepad_provider_unittest.cc ('K') | « device/gamepad/gamepad_provider_unittest.cc ('k') | device/gamepad/gamepad_standard_mappings.h » ('j') | device/gamepad/gamepad_standard_mappings.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DEVICE_GAMEPAD_HARDWARE_BUFFER_H_
	scottmg 2016/06/23 17:27:19 This doesn't match the file name. This doesn't match the file name.
	6 #define DEVICE_GAMEPAD_HARDWARE_BUFFER_H_

	7

	8 #include "base/memory/shared_memory.h"

	9 #include "device/gamepad/gamepad_export.h"

	10 #include "third_party/WebKit/public/platform/WebGamepads.h"

	11

	12 namespace device {

	13

	14 class DEVICE_GAMEPAD_EXPORT GamepadSharedBuffer {

	15 public:
	scottmg 2016/06/23 17:27:19 I think you have to have a virtual ~GamepadSharedB I think you have to have a virtual ~GamepadSharedBuffer() here, else ~GamepadSharedBufferImpl() mightn't get called.
	16 virtual base::SharedMemory* shared_memory() = 0;

	17 virtual blink::WebGamepads* buffer() = 0;

	18

	19 virtual void WriteBegin() = 0;

	20 virtual void WriteEnd() = 0;

	21 };

	22

	23 } // namespace device

	24

	25 #endif // DEVICE_GAMEPAD_HARDWARE_BUFFER_H_

OLD	NEW