Componentize Chrome terms of service, Accept-Languages & default encoding.

Componentize Chrome terms of service, Accept-Languages & default encoding.

In order to share those strings with Chrome on iOS, componentize the
strings IDS_TERMS_HTML, IDS_ACCEPT_LANGUAGES, IDS_DEFAULT_ENCODING.

Remove usafe of IDS_IOS_ACCEPT_LANGUAGES and IDS_IOS_DEFAULT_ENCODING
as they are duplicates of the newly componentized strings (but do not
remove them yet as they are still used downstream).

Fix the script packing the resources to pack those new generated .pak
files for both iOS and other platforms.

BUG=568486
Committed: https://crrev.com/7807dc30a3bf812e716ac8efcf9c48a675e9e170
Cr-Commit-Position: refs/heads/master@{#374951}

[sdefresne, 2016-02-09 12:52:03]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-09 12:52:04]

Please take a look.

[droger, 2016-02-09 13:50:54]

lgtm

https://codereview.chromium.org/1679283002/diff/1/chrome/chrome_repack_locale...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/1679283002/diff/1/chrome/chrome_repack_locale...
chrome/chrome_repack_locales.gni:37:
"//chrome/app/resources:platform_locale_settings",
Add 
"//components/strings:components_locale_settings",

[sdefresne, 2016-02-09 16:34:19]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2016-02-09 16:34:20]

+thakis for OWNERS for

  chrome/browser/android/preferences/pref_service_bridge.cc
  chrome/browser/first_run/first_run_internal_win.cc
  chrome/browser/ui/prefs/prefs_tab_helper.cc
  chrome/browser/ui/webui/about_ui.cc
  chrome/chrome_repack_locales.gni
  chrome/tools/build/repack_locales.py
  tools/copyright_scanner/third_party_files_whitelist.txt
  tools/gritsettings/resource_ids
  tools/gritsettings/translation_expectations.pyl

https://codereview.chromium.org/1679283002/diff/1/chrome/chrome_repack_locale...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/1679283002/diff/1/chrome/chrome_repack_locale...
chrome/chrome_repack_locales.gni:37:
"//chrome/app/resources:platform_locale_settings",
On 2016/02/09 at 13:50:54, droger wrote:
> Add 
> "//components/strings:components_locale_settings",

Good catch, thank you.

[sdefresne, 2016-02-10 15:54:40]

thakis: ping?

[Nico, 2016-02-11 17:43:18]

basically lgtm, but can we use qualified includes for the new generated headers
please?

https://codereview.chromium.org/1679283002/diff/10001/chrome/browser/android/...
File chrome/browser/android/preferences/pref_service_bridge.cc (right):

https://codereview.chromium.org/1679283002/diff/10001/chrome/browser/android/...
chrome/browser/android/preferences/pref_service_bridge.cc:49: #include
"grit/components_locale_settings.h"
you've seen http://crbug.com/401588 -- is it possible to use a qualified include
here?

[Nico, 2016-02-11 17:43:33]

On 2016/02/11 17:43:18, Nico wrote:
> basically lgtm, but can we use qualified includes for the new generated
headers
> please?
> 
>
https://codereview.chromium.org/1679283002/diff/10001/chrome/browser/android/...
> File chrome/browser/android/preferences/pref_service_bridge.cc (right):
> 
>
https://codereview.chromium.org/1679283002/diff/10001/chrome/browser/android/...
> chrome/browser/android/preferences/pref_service_bridge.cc:49: #include
> "grit/components_locale_settings.h"
> you've seen http://crbug.com/401588 -- is it possible to use a qualified
include
> here?

(and in the other files too, of course)

[sdefresne, 2016-02-11 18:28:52]

Thank you for the review.

https://codereview.chromium.org/1679283002/diff/10001/chrome/browser/android/...
File chrome/browser/android/preferences/pref_service_bridge.cc (right):

https://codereview.chromium.org/1679283002/diff/10001/chrome/browser/android/...
chrome/browser/android/preferences/pref_service_bridge.cc:49: #include
"grit/components_locale_settings.h"
On 2016/02/11 at 17:43:18, Nico wrote:
> you've seen http://crbug.com/401588 -- is it possible to use a qualified
include here?

Sure, done here and everywhere else.

[sdefresne, 2016-02-11 18:31:23]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-02-11 18:31:24]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1679283002/#ps20001
(title: "Rebase && use a qualified include for the new file")

[commit-bot: I haz the power, 2016-02-11 18:35:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679283002/20001

[commit-bot: I haz the power, 2016-02-11 20:00:47]

Committed patchset #3 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:36:59]

Description was changed from

==========
Componentize Chrome terms of service, Accept-Languages & default encoding.

In order to share those strings with Chrome on iOS, componentize the
strings IDS_TERMS_HTML, IDS_ACCEPT_LANGUAGES, IDS_DEFAULT_ENCODING.

Remove usafe of IDS_IOS_ACCEPT_LANGUAGES and IDS_IOS_DEFAULT_ENCODING
as they are duplicates of the newly componentized strings (but do not
remove them yet as they are still used downstream).

Fix the script packing the resources to pack those new generated .pak
files for both iOS and other platforms.

BUG=568486
==========

to

==========
Componentize Chrome terms of service, Accept-Languages & default encoding.

In order to share those strings with Chrome on iOS, componentize the
strings IDS_TERMS_HTML, IDS_ACCEPT_LANGUAGES, IDS_DEFAULT_ENCODING.

Remove usafe of IDS_IOS_ACCEPT_LANGUAGES and IDS_IOS_DEFAULT_ENCODING
as they are duplicates of the newly componentized strings (but do not
remove them yet as they are still used downstream).

Fix the script packing the resources to pack those new generated .pak
files for both iOS and other platforms.

BUG=568486

Committed: https://crrev.com/7807dc30a3bf812e716ac8efcf9c48a675e9e170
Cr-Commit-Position: refs/heads/master@{#374951}
==========

[commit-bot: I haz the power, 2016-02-16 22:37:01]

Patchset 3 (id:??) landed as
https://crrev.com/7807dc30a3bf812e716ac8efcf9c48a675e9e170
Cr-Commit-Position: refs/heads/master@{#374951}