Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/chrome_repack_locales.gni

Issue 1679283002: Componentize Chrome terms of service, Accept-Languages & default encoding. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | chrome/tools/build/repack_locales.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//tools/grit/repack.gni") 8 import("//tools/grit/repack.gni")
9 9
10 # Arguments: 10 # Arguments:
(...skipping 10 matching lines...) Expand all
21 locale = invoker.locale 21 locale = invoker.locale
22 22
23 repack(target_name) { 23 repack(target_name) {
24 visibility = invoker.visibility 24 visibility = invoker.visibility
25 25
26 # Each input pak file should also have a deps line for completeness. 26 # Each input pak file should also have a deps line for completeness.
27 sources = [ 27 sources = [
28 "${root_gen_dir}/chrome/generated_resources_${locale}.pak", 28 "${root_gen_dir}/chrome/generated_resources_${locale}.pak",
29 "${root_gen_dir}/chrome/locale_settings_${locale}.pak", 29 "${root_gen_dir}/chrome/locale_settings_${locale}.pak",
30 "${root_gen_dir}/chrome/platform_locale_settings_${locale}.pak", 30 "${root_gen_dir}/chrome/platform_locale_settings_${locale}.pak",
31 "${root_gen_dir}/components/strings/components_locale_settings_${locale}.p ak",
31 "${root_gen_dir}/components/strings/components_strings_${locale}.pak", 32 "${root_gen_dir}/components/strings/components_strings_${locale}.pak",
32 ] 33 ]
33 deps = [ 34 deps = [
34 "//chrome/app:generated_resources", 35 "//chrome/app:generated_resources",
35 "//chrome/app/resources:locale_settings", 36 "//chrome/app/resources:locale_settings",
36 "//chrome/app/resources:platform_locale_settings", 37 "//chrome/app/resources:platform_locale_settings",
droger 2016/02/09 13:50:54 Add "//components/strings:components_locale_setti
sdefresne 2016/02/09 16:34:20 Good catch, thank you.
37 "//components/strings:components_strings", 38 "//components/strings:components_strings",
38 ] 39 ]
39 40
40 # The settings strings are not being treated as strings because they are 41 # The settings strings are not being treated as strings because they are
41 # not translated (English only), this should change in late 2015. 42 # not translated (English only), this should change in late 2015.
42 sources += [ "${root_gen_dir}/chrome/settings_strings.pak" ] 43 sources += [ "${root_gen_dir}/chrome/settings_strings.pak" ]
43 deps += [ "//chrome/app:settings_strings" ] 44 deps += [ "//chrome/app:settings_strings" ]
44 45
45 if (use_ash) { 46 if (use_ash) {
46 sources += [ "${root_gen_dir}/ash/strings/ash_strings_${locale}.pak" ] 47 sources += [ "${root_gen_dir}/ash/strings/ash_strings_${locale}.pak" ]
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 170
170 current_index = current_index + 1 171 current_index = current_index + 1
171 } 172 }
172 173
173 # The group that external targets depend on which collects all deps. 174 # The group that external targets depend on which collects all deps.
174 group(group_target_name) { 175 group(group_target_name) {
175 forward_variables_from(invoker, [ "visibility" ]) 176 forward_variables_from(invoker, [ "visibility" ])
176 public_deps = locale_targets 177 public_deps = locale_targets
177 } 178 }
178 } 179 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/about_ui.cc ('k') | chrome/tools/build/repack_locales.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698