Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001913003: Remove <canvas> (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove <canvas> Folks should use custom paint instead (see sky/engine/core/painting for a sketch). R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a4d8d8c98699bda5ac1f86078a57a19669b9e298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21814 lines) Patch
M sky/engine/core/core.gni View 5 chunks +0 lines, -156 lines 0 comments Download
M sky/engine/core/dom/Document.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/editing/Editor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/ImageBitmap.h View 3 chunks +1 line, -10 lines 0 comments Download
M sky/engine/core/frame/ImageBitmap.cpp View 4 chunks +0 lines, -46 lines 0 comments Download
M sky/engine/core/frame/ImageBitmapTest.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
D sky/engine/core/html/HTMLCanvasElement.h View 1 chunk +0 lines, -199 lines 0 comments Download
D sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -655 lines 0 comments Download
D sky/engine/core/html/HTMLCanvasElement.idl View 1 chunk +0 lines, -35 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 3 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 3 chunks +0 lines, -49 lines 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/html/canvas/ANGLEInstancedArrays.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/html/canvas/ANGLEInstancedArrays.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/engine/core/html/canvas/ANGLEInstancedArrays.idl View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/engine/core/html/canvas/ArrayBufferView.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/engine/core/html/canvas/Canvas2DContextAttributes.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/html/canvas/Canvas2DContextAttributes.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/engine/core/html/canvas/Canvas2DContextAttributes.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasContextAttributes.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasContextAttributes.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasGradient.h View 1 chunk +0 lines, -66 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasGradient.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasGradient.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasImageSource.h View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasPathMethods.h View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasPathMethods.cpp View 1 chunk +0 lines, -321 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasPathMethods.idl View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasPattern.h View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasPattern.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasPattern.idl View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasRenderingContext.h View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasRenderingContext.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +0 lines, -359 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +0 lines, -2210 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +0 lines, -174 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasStyle.h View 1 chunk +0 lines, -106 lines 0 comments Download
D sky/engine/core/html/canvas/CanvasStyle.cpp View 1 chunk +0 lines, -275 lines 0 comments Download
D sky/engine/core/html/canvas/DataView.h View 1 chunk +0 lines, -99 lines 0 comments Download
D sky/engine/core/html/canvas/DataView.cpp View 1 chunk +0 lines, -247 lines 0 comments Download
D sky/engine/core/html/canvas/DataView.idl View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/core/html/canvas/EXTBlendMinMax.h View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/engine/core/html/canvas/EXTBlendMinMax.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/engine/core/html/canvas/EXTBlendMinMax.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/engine/core/html/canvas/EXTFragDepth.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/EXTFragDepth.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/EXTFragDepth.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/html/canvas/EXTShaderTextureLOD.h View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/engine/core/html/canvas/EXTShaderTextureLOD.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/engine/core/html/canvas/EXTShaderTextureLOD.idl View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/engine/core/html/canvas/EXTTextureFilterAnisotropic.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/EXTTextureFilterAnisotropic.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/EXTTextureFilterAnisotropic.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/HitRegion.h View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/engine/core/html/canvas/HitRegion.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
D sky/engine/core/html/canvas/OESElementIndexUint.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/OESElementIndexUint.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/OESElementIndexUint.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/html/canvas/OESStandardDerivatives.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/OESStandardDerivatives.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/OESStandardDerivatives.idl View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureFloat.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureFloat.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureFloat.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureFloatLinear.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureFloatLinear.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureFloatLinear.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureHalfFloat.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureHalfFloat.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureHalfFloat.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureHalfFloatLinear.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureHalfFloatLinear.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/OESTextureHalfFloatLinear.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/html/canvas/OESVertexArrayObject.h View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/engine/core/html/canvas/OESVertexArrayObject.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D sky/engine/core/html/canvas/OESVertexArrayObject.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/engine/core/html/canvas/Path2D.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/core/html/canvas/Path2D.idl View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLActiveInfo.h View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLActiveInfo.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLBuffer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLBuffer.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLBuffer.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureATC.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureATC.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureATC.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureETC1.h View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureETC1.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureETC1.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTexturePVRTC.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTexturePVRTC.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTexturePVRTC.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureS3TC.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureS3TC.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLCompressedTextureS3TC.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextAttributes.h View 1 chunk +0 lines, -102 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextAttributes.cpp View 1 chunk +0 lines, -169 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextAttributes.idl View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextEvent.h View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextEvent.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextEvent.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextGroup.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextGroup.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextObject.h View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLContextObject.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDebugRendererInfo.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDebugRendererInfo.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDebugRendererInfo.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDebugShaders.h View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDebugShaders.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDebugShaders.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDepthTexture.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDepthTexture.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDepthTexture.idl View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDrawBuffers.h View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDrawBuffers.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLDrawBuffers.idl View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLExtension.h View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLExtension.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLExtensionName.h View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLFramebuffer.h View 1 chunk +0 lines, -135 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLFramebuffer.cpp View 1 chunk +0 lines, -615 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLFramebuffer.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLGetInfo.h View 1 chunk +0 lines, -141 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLGetInfo.cpp View 1 chunk +0 lines, -303 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLLoseContext.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLLoseContext.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLLoseContext.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLObject.h View 1 chunk +0 lines, -88 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLObject.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLProgram.h View 1 chunk +0 lines, -90 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLProgram.cpp View 1 chunk +0 lines, -205 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLProgram.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderbuffer.h View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderbuffer.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderbuffer.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderingContext.h View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderingContext.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderingContextBase.h View 1 chunk +0 lines, -942 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -5613 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +0 lines, -683 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLShader.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLShader.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLShader.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLShaderPrecisionFormat.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLShaderPrecisionFormat.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLShaderPrecisionFormat.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLSharedObject.h View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLSharedObject.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLSharedWebGraphicsContext3D.h View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLSharedWebGraphicsContext3D.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLTexture.h View 1 chunk +0 lines, -139 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLTexture.cpp View 1 chunk +0 lines, -390 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLTexture.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLUniformLocation.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLUniformLocation.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLUniformLocation.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.h View 1 chunk +0 lines, -125 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.cpp View 1 chunk +0 lines, -164 lines 0 comments Download
D sky/engine/core/html/canvas/WebGLVertexArrayObjectOES.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/rendering/RenderHTMLCanvas.h View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/engine/core/rendering/RenderHTMLCanvas.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
D sky/tests/clipping/canvas-rounded-corners.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/clipping/canvas-rounded-corners-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-25 23:07:28 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-25 23:08:50 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-25 23:15:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a4d8d8c98699bda5ac1f86078a57a19669b9e298 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698