[sql] Remove SQLite 3.10.2 reference directory.

[sql] Remove SQLite 3.10.2 reference directory.

The 3.17.0 import seems to have stuck, so I think rollback is pretty
unlikely at this point.

BUG=701518
TBR=pwnall@chromium.org

Review-Url: https://codereview.chromium.org/2846743003
Cr-Commit-Position: refs/heads/master@{#467763}
Committed: https://chromium.googlesource.com/chromium/src/+/21012337efeac39dc18f53c5a793c50b361a1ba1

[Scott Hess - ex-Googler, 2017-04-27 19:03:52]

Description was changed from

==========
[sql] Remove SQLite 3.10.2 reference directory.

The 3.17.0 import seems to have stuck, so I think rollback is pretty
unlikely at this point.

BUG=701518
R=pwnall@chromium.org
==========

to

==========
[sql] Remove SQLite 3.10.2 reference directory.

The 3.17.0 import seems to have stuck, so I think rollback is pretty
unlikely at this point.

BUG=701518
TBR=pwnall@chromium.org
==========

[Scott Hess - ex-Googler, 2017-04-27 19:06:09]

Just FYI, I'm landing TBR because this code is for reference only, it is not
part of any build.  The the most likely problem is that the bots can't apply the
patch and I have to land it manually.

[Scott Hess - ex-Googler, 2017-04-27 19:06:45]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:07:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:26:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493320005607060, "parent_rev":
"8cabc77f6204866cbcdc8d581e130f287acaeb06", "commit_rev":
"21012337efeac39dc18f53c5a793c50b361a1ba1"}

[commit-bot: I haz the power, 2017-04-27 20:26:15]

Description was changed from

==========
[sql] Remove SQLite 3.10.2 reference directory.

The 3.17.0 import seems to have stuck, so I think rollback is pretty
unlikely at this point.

BUG=701518
TBR=pwnall@chromium.org
==========

to

==========
[sql] Remove SQLite 3.10.2 reference directory.

The 3.17.0 import seems to have stuck, so I think rollback is pretty
unlikely at this point.

BUG=701518
TBR=pwnall@chromium.org

Review-Url: https://codereview.chromium.org/2846743003
Cr-Commit-Position: refs/heads/master@{#467763}
Committed:
https://chromium.googlesource.com/chromium/src/+/21012337efeac39dc18f53c5a793...
==========

[commit-bot: I haz the power, 2017-04-27 20:26:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21012337efeac39dc18f53c5a793...

[pwnall, 2017-04-27 20:27:52]

LGTM.

I saw these dirs and wondered why we still have them. We can always get old
versions from git, right? :)

[pwnall, 2017-04-27 20:27:59]

LGTM.

I saw these dirs and wondered why we still have them. We can always get old
versions from git, right? :)

[Scott Hess - ex-Googler, 2017-04-27 20:36:02]

The reason we keep both sqlite-src-3170000/ and src/ is because it is
useful/important to have a way to reason about the state of the code,
especially when making new changes.  One approach that works well is to use
a vendor import branch, which is the un-patched original code, which you
then diff against and/or do integrates against.  Unfortunately, that's not
something we can cleanly do in the overall Chromium system.  So I just do
it manually.

[The reason to keep a local version of the vendor tree is so that we are in
control of what we are diffing or patching.  Otherwise you can end up in a
place where the vendor has moved on and you can no longer find reference
copies of what you need.  IMHO SQLite is really good in this area, I've
just been bitten by this in the past, and it's really annoying when it
happens.]

-scott


On Thu, Apr 27, 2017 at 1:27 PM, <pwnall@chromium.org> wrote:

> LGTM.
>
> I saw these dirs and wondered why we still have them. We can always get old
> versions from git, right? :)
>
> https://codereview.chromium.org/2846743003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.