Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2808093006: [Device Service] Move Gamepad Blink headers to be part of the Gamepad client library (Closed)

Created:
3 years, 8 months ago by juncai
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, feature-vr-reviews_chromium.org, jam, jochen+watch_chromium.org, mac-reviews_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Device Service] Move Gamepad Blink headers to be part of the Gamepad client library This CL follows the approach of https://codereview.chromium.org/2415083002 and moves //third_party/WebKit/public/platform/WebGamepad.h //third_party/WebKit/public/platform/WebGamepads.h to //device/gamepad/public/cpp/ and puts them in a special target to indicate that they're shared with Blink BUG=695012 Review-Url: https://codereview.chromium.org/2808093006 Cr-Commit-Position: refs/heads/master@{#465129} Committed: https://chromium.googlesource.com/chromium/src/+/2f298a80296e8510f74632faa55e825cfe41ec4f

Patch Set 1 : move Gamepad Blink headers to be part of the Gamepad client library #

Patch Set 2 : clean up code #

Patch Set 3 : rebase #

Patch Set 4 : fix some BUILD.gn #

Patch Set 5 : fix presubmit warning #

Patch Set 6 : fix chromeos compile errors #

Patch Set 7 : fix linux check deps #

Patch Set 8 : clean up code #

Total comments: 18

Patch Set 9 : address comments #

Total comments: 2

Patch Set 10 : rebase and address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+774 lines, -808 lines) Patch
M components/exo/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/gaming_seat.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M components/exo/gaming_seat.cc View 1 2 3 4 5 5 chunks +7 lines, -7 lines 0 comments Download
M components/exo/gaming_seat_unittest.cc View 1 2 3 4 5 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/DEPS View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_gamepad_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M content/common/DEPS View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/renderer/renderer_gamepad_provider.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gamepad_shared_memory_reader.h View 3 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/gamepad_shared_memory_reader.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 5 6 7 8 9 4 chunks +2 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/test_runner/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/test_runner/gamepad_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/test_runner/gamepad_controller.cc View 1 2 3 4 5 6 7 3 chunks +19 lines, -19 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -3 lines 0 comments Download
M device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/gamepad/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M device/gamepad/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M device/gamepad/game_controller_data_fetcher_mac.mm View 2 chunks +3 lines, -6 lines 0 comments Download
M device/gamepad/gamepad_consumer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M device/gamepad/gamepad_monitor.h View 1 chunk +2 lines, -4 lines 0 comments Download
M device/gamepad/gamepad_monitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/gamepad/gamepad_pad_state_provider.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M device/gamepad/gamepad_pad_state_provider.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_android.h View 1 chunk +1 line, -1 line 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_android.cc View 5 chunks +12 lines, -17 lines 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_linux.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_linux.cc View 1 2 3 4 5 6 7 8 9 chunks +11 lines, -14 lines 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_mac.h View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -6 lines 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_mac.mm View 9 chunks +20 lines, -23 lines 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_win.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M device/gamepad/gamepad_provider.h View 4 chunks +4 lines, -7 lines 0 comments Download
M device/gamepad/gamepad_provider.cc View 8 chunks +10 lines, -13 lines 0 comments Download
M device/gamepad/gamepad_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 13 chunks +15 lines, -17 lines 0 comments Download
M device/gamepad/gamepad_service.h View 1 3 chunks +3 lines, -7 lines 0 comments Download
M device/gamepad/gamepad_service.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M device/gamepad/gamepad_service_unittest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M device/gamepad/gamepad_shared_buffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M device/gamepad/gamepad_shared_buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings.h View 2 chunks +9 lines, -11 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings_linux.cc View 15 chunks +15 lines, -24 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings_mac.mm View 16 chunks +16 lines, -26 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings_win.cc View 10 chunks +15 lines, -20 lines 0 comments Download
M device/gamepad/gamepad_test_helpers.h View 4 chunks +5 lines, -5 lines 0 comments Download
M device/gamepad/gamepad_test_helpers.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M device/gamepad/gamepad_user_gesture.h View 1 chunk +3 lines, -5 lines 0 comments Download
M device/gamepad/gamepad_user_gesture.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A device/gamepad/public/cpp/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A device/gamepad/public/cpp/gamepad.h View 1 2 3 4 5 6 7 8 1 chunk +115 lines, -0 lines 0 comments Download
A device/gamepad/public/cpp/gamepad.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A device/gamepad/public/cpp/gamepads.h View 1 2 3 4 5 6 7 8 1 chunk +29 lines, -0 lines 0 comments Download
M device/gamepad/public/interfaces/OWNERS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M device/gamepad/public/interfaces/gamepad.typemap View 2 chunks +7 lines, -7 lines 0 comments Download
M device/gamepad/public/interfaces/gamepad_struct_traits.h View 1 chunk +50 lines, -56 lines 0 comments Download
M device/gamepad/public/interfaces/gamepad_struct_traits.cc View 1 2 3 4 5 6 7 8 12 chunks +43 lines, -47 lines 0 comments Download
M device/gamepad/public/interfaces/gamepad_struct_traits_unittest.cc View 1 2 3 4 5 6 7 8 7 chunks +42 lines, -48 lines 0 comments Download
M device/gamepad/raw_input_data_fetcher_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
M device/gamepad/raw_input_data_fetcher_win.cc View 10 chunks +13 lines, -16 lines 0 comments Download
M device/gamepad/xbox_data_fetcher_mac.mm View 3 chunks +3 lines, -5 lines 0 comments Download
M device/vr/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_gamepad_data_fetcher.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -13 lines 0 comments Download
M ppapi/shared_impl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.cc View 1 2 3 4 5 6 7 8 9 2 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/Gamepad.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/Gamepad.cpp View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadPose.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadPose.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 3 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -2 lines 0 comments Download
D third_party/WebKit/public/platform/WebGamepad.h View 1 chunk +0 lines, -137 lines 0 comments Download
M third_party/WebKit/public/platform/WebGamepadListener.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -4 lines 0 comments Download
D third_party/WebKit/public/platform/WebGamepads.h View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 55 (42 generated)
juncai
reveman@chromium.org: Please review changes in //components/exo/ jam@chromium.org: Please review changes in //content/ mattreynolds@chromium.org: Please review ...
3 years, 8 months ago (2017-04-12 22:33:34 UTC) #31
jam
lgtm https://codereview.chromium.org/2808093006/diff/130001/third_party/WebKit/public/platform/Platform.h File third_party/WebKit/public/platform/Platform.h (right): https://codereview.chromium.org/2808093006/diff/130001/third_party/WebKit/public/platform/Platform.h#newcode283 third_party/WebKit/public/platform/Platform.h:283: virtual void SampleGamepads(device::Gamepads& into) {} this can just ...
3 years, 8 months ago (2017-04-12 23:02:19 UTC) #32
dcheng
LGTM for mojo https://codereview.chromium.org/2808093006/diff/130001/device/gamepad/gamepad_platform_data_fetcher_mac.mm File device/gamepad/gamepad_platform_data_fetcher_mac.mm (right): https://codereview.chromium.org/2808093006/diff/130001/device/gamepad/gamepad_platform_data_fetcher_mac.mm#newcode26 device/gamepad/gamepad_platform_data_fetcher_mac.mm:26: UChar* dest, Nit: do we need ...
3 years, 8 months ago (2017-04-12 23:33:27 UTC) #33
reveman
lgtm
3 years, 8 months ago (2017-04-12 23:56:46 UTC) #34
mattreynolds
lgtm https://codereview.chromium.org/2808093006/diff/130001/device/gamepad/gamepad_platform_data_fetcher_linux.cc File device/gamepad/gamepad_platform_data_fetcher_linux.cc (right): https://codereview.chromium.org/2808093006/diff/130001/device/gamepad/gamepad_platform_data_fetcher_linux.cc#newcode228 device/gamepad/gamepad_platform_data_fetcher_linux.cc:228: // Linker does not like CHECK_LT(index, Gamepads::itemsLengthCap). =/ ...
3 years, 8 months ago (2017-04-13 01:53:34 UTC) #35
haraken
WebKit/ LGTM with jam's comment addressed.
3 years, 8 months ago (2017-04-13 01:54:37 UTC) #36
juncai
https://codereview.chromium.org/2808093006/diff/130001/device/gamepad/gamepad_platform_data_fetcher_linux.cc File device/gamepad/gamepad_platform_data_fetcher_linux.cc (right): https://codereview.chromium.org/2808093006/diff/130001/device/gamepad/gamepad_platform_data_fetcher_linux.cc#newcode228 device/gamepad/gamepad_platform_data_fetcher_linux.cc:228: // Linker does not like CHECK_LT(index, Gamepads::itemsLengthCap). =/ On ...
3 years, 8 months ago (2017-04-13 23:55:52 UTC) #41
bbudge
lgtm w/comment https://codereview.chromium.org/2808093006/diff/150001/ppapi/shared_impl/ppb_gamepad_shared.cc File ppapi/shared_impl/ppb_gamepad_shared.cc (right): https://codereview.chromium.org/2808093006/diff/150001/ppapi/shared_impl/ppb_gamepad_shared.cc#newcode17 ppapi/shared_impl/ppb_gamepad_shared.cc:17: void ConvertWebKitGamepadData(const WebKitGamepads& webkit_data, Is there a ...
3 years, 8 months ago (2017-04-14 00:57:33 UTC) #42
juncai
ping bajones@, :), please review changes in //device/vr/
3 years, 8 months ago (2017-04-17 17:21:42 UTC) #43
bajones
On 2017/04/17 17:21:42, juncai wrote: > ping bajones@, :), please review changes in > //device/vr/ ...
3 years, 8 months ago (2017-04-17 17:31:19 UTC) #44
juncai
https://codereview.chromium.org/2808093006/diff/150001/ppapi/shared_impl/ppb_gamepad_shared.cc File ppapi/shared_impl/ppb_gamepad_shared.cc (right): https://codereview.chromium.org/2808093006/diff/150001/ppapi/shared_impl/ppb_gamepad_shared.cc#newcode17 ppapi/shared_impl/ppb_gamepad_shared.cc:17: void ConvertWebKitGamepadData(const WebKitGamepads& webkit_data, On 2017/04/14 00:57:32, bbudge wrote: ...
3 years, 8 months ago (2017-04-18 03:43:52 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808093006/170001
3 years, 8 months ago (2017-04-18 03:44:27 UTC) #52
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 03:51:54 UTC) #55
Message was sent while issue was closed.
Committed patchset #10 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/2f298a80296e8510f74632faa55e...

Powered by Google App Engine
This is Rietveld 408576698