clang/win: Let remaining chromium_code targets build with -Wextra.

clang/win: Let remaining chromium_code targets build with -Wextra.

This is a follow-up to https://codereview.chromium.org/1507413003/ and
lets all translation units in a release build build if -Wextra is enabled
for chromium_code targets.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
Committed: https://crrev.com/6ef917b3602be64cc612dfbd78e45f1f80e4d8dd
Cr-Commit-Position: refs/heads/master@{#364425}

[Nico, 2015-12-09 20:19:13]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 20:20:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513043002/1

[Nico, 2015-12-09 20:22:46]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2015-12-09 20:22:47]

https://codereview.chromium.org/1513043002/diff/1/device/hid/hid_service_win.cc
File device/hid/hid_service_win.cc (right):

https://codereview.chromium.org/1513043002/diff/1/device/hid/hid_service_win....
device/hid/hid_service_win.cc:293: if (!file.IsValid() && GetLastError() ==
ERROR_ACCESS_DENIED) {
this was a bug

[commit-bot: I haz the power, 2015-12-09 21:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 21:20:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Lei Zhang, 2015-12-09 22:17:14]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-12-09 22:17:15]

I looked over the chrome/ half -> lgtm

https://codereview.chromium.org/1513043002/diff/1/chrome/browser/autocomplete...
File chrome/browser/autocomplete/in_memory_url_index_unittest.cc (right):

https://codereview.chromium.org/1513043002/diff/1/chrome/browser/autocomplete...
chrome/browser/autocomplete/in_memory_url_index_unittest.cc:1034: EXPECT_EQ(3u,
visits.size());
ASSERT_EQ(), ditto below, sigh.

https://codereview.chromium.org/1513043002/diff/1/chrome/browser/autocomplete...
chrome/browser/autocomplete/in_memory_url_index_unittest.cc:1035:
EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[0].second);
Maybe just use the enum values?

[Nico, 2015-12-09 22:22:36]

thanks

https://codereview.chromium.org/1513043002/diff/1/chrome/browser/autocomplete...
File chrome/browser/autocomplete/in_memory_url_index_unittest.cc (right):

https://codereview.chromium.org/1513043002/diff/1/chrome/browser/autocomplete...
chrome/browser/autocomplete/in_memory_url_index_unittest.cc:1034: EXPECT_EQ(3u,
visits.size());
On 2015/12/09 22:17:15, Lei Zhang wrote:
> ASSERT_EQ(), ditto below, sigh.

Done.

https://codereview.chromium.org/1513043002/diff/1/chrome/browser/autocomplete...
chrome/browser/autocomplete/in_memory_url_index_unittest.cc:1035:
EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[0].second);
On 2015/12/09 22:17:15, Lei Zhang wrote:
> Maybe just use the enum values?

I figured this uses literal ints to also test that the enum values don't change,
so I kept this.

[Nico, 2015-12-09 22:22:47]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 22:27:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513043002/20001

[commit-bot: I haz the power, 2015-12-10 00:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 00:05:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[brettw, 2015-12-10 17:49:05]

non-chrome LGTM

[Nico, 2015-12-10 17:56:51]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-12-10 17:56:51]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1513043002/#ps20001
(title: "thestig")

[Nico, 2015-12-10 17:57:02]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2015-12-10 18:14:32]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-12-10 18:14:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1513043002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2015-12-10 18:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513043002/40001

[commit-bot: I haz the power, 2015-12-10 19:30:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-10 19:30:53]

Description was changed from

==========
clang/win: Let remaining chromium_code targets build with -Wextra.

This is a follow-up to https://codereview.chromium.org/1507413003/ and
lets all translation units in a release build build if -Wextra is enabled
for chromium_code targets.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877
==========

to

==========
clang/win: Let remaining chromium_code targets build with -Wextra.

This is a follow-up to https://codereview.chromium.org/1507413003/ and
lets all translation units in a release build build if -Wextra is enabled
for chromium_code targets.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877

Committed: https://crrev.com/6ef917b3602be64cc612dfbd78e45f1f80e4d8dd
Cr-Commit-Position: refs/heads/master@{#364425}
==========

[commit-bot: I haz the power, 2015-12-10 19:30:54]

Patchset 3 (id:??) landed as
https://crrev.com/6ef917b3602be64cc612dfbd78e45f1f80e4d8dd
Cr-Commit-Position: refs/heads/master@{#364425}