clang/win: Let remaining chromium_code targets build with -Wextra.

cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cloud_print/virtual_driver/win/port_monitor/port_monitor.h"
 
 #include <winspool.h>
 
 #include "base/files/file_util.h"
 #include "base/path_service.h"
@@ skipping 125 matching lines @@
 TEST_F(PortMonitorTest, EnumPortsTest) {
   DWORD needed_bytes = 0;
   DWORD returned = 0;
   EXPECT_FALSE(Monitor2EnumPorts(NULL,
                                  NULL,
                                  1,
                                  NULL,
                                  0,
                                  &needed_bytes,
                                  &returned));
-  EXPECT_EQ(ERROR_INSUFFICIENT_BUFFER, GetLastError());
+  EXPECT_EQ(static_cast<DWORD>(ERROR_INSUFFICIENT_BUFFER), GetLastError());
   EXPECT_NE(0u, needed_bytes);
   EXPECT_EQ(0u, returned);
 
   BYTE* buffer = new BYTE[needed_bytes];
   ASSERT_TRUE(buffer != NULL);
   EXPECT_TRUE(Monitor2EnumPorts(NULL,
                                 NULL,
                                 1,
                                 buffer,
                                 needed_bytes,
                                 &needed_bytes,
                                 &returned));
   EXPECT_NE(0u, needed_bytes);
   EXPECT_EQ(1u, returned);
   PORT_INFO_1* port_info_1 = reinterpret_cast<PORT_INFO_1*>(buffer);
   EXPECT_TRUE(port_info_1->pName != NULL);
   delete[] buffer;
 
   returned = 0;
   needed_bytes = 0;
   EXPECT_FALSE(Monitor2EnumPorts(NULL,
                                  NULL,
                                  2,
                                  NULL,
                                  0,
                                  &needed_bytes,
                                  &returned));
-  EXPECT_EQ(ERROR_INSUFFICIENT_BUFFER, GetLastError());
+  EXPECT_EQ(static_cast<DWORD>(ERROR_INSUFFICIENT_BUFFER), GetLastError());
   EXPECT_NE(0u, needed_bytes);
   EXPECT_EQ(0u, returned);
 
   buffer = new BYTE[needed_bytes];
   ASSERT_TRUE(buffer != NULL);
   EXPECT_TRUE(Monitor2EnumPorts(NULL,
                                 NULL,
                                 2,
                                 buffer,
                                 needed_bytes,
@@ skipping 21 matching lines @@
   MONITOR2* monitor2 = InitializePrintMonitor2(&monitor_init, &monitor_handle);
   EXPECT_TRUE(monitor2 != NULL);
   EXPECT_TRUE(monitor_handle != NULL);
 
   // Test the XCV functions.  Used for reporting the location of the
   // UI portion of the port monitor.
   EXPECT_TRUE(monitor2->pfnXcvOpenPort != NULL);
   EXPECT_TRUE(monitor2->pfnXcvOpenPort(monitor_handle, NULL, 0, &xcv_handle));
   EXPECT_TRUE(xcv_handle != NULL);
   EXPECT_TRUE(monitor2->pfnXcvDataPort != NULL);
-  EXPECT_EQ(ERROR_ACCESS_DENIED,
-            monitor2->pfnXcvDataPort(xcv_handle,
-                                     kXcvDataItem,
-                                     NULL,
-                                     0,
-                                     buffer,
-                                     kBufferSize,
-                                     &bytes_needed));
+  EXPECT_EQ(static_cast<DWORD>(ERROR_ACCESS_DENIED),
+            monitor2->pfnXcvDataPort(xcv_handle, kXcvDataItem, NULL, 0, buffer,
+                                     kBufferSize, &bytes_needed));
   EXPECT_TRUE(monitor2->pfnXcvClosePort != NULL);
   EXPECT_TRUE(monitor2->pfnXcvClosePort(xcv_handle));
   EXPECT_TRUE(monitor2->pfnXcvOpenPort(monitor_handle,
                                        NULL,
                                        SERVER_ACCESS_ADMINISTER,
                                        &xcv_handle));
   EXPECT_TRUE(xcv_handle != NULL);
   EXPECT_TRUE(monitor2->pfnXcvDataPort != NULL);
-  EXPECT_EQ(ERROR_SUCCESS,
-            monitor2->pfnXcvDataPort(xcv_handle,
-                                     kXcvDataItem,
-                                     NULL,
-                                     0,
-                                     buffer,
-                                     kBufferSize,
-                                     &bytes_needed));
+  EXPECT_EQ(static_cast<DWORD>(ERROR_SUCCESS),
+            monitor2->pfnXcvDataPort(xcv_handle, kXcvDataItem, NULL, 0, buffer,
+                                     kBufferSize, &bytes_needed));
   EXPECT_TRUE(monitor2->pfnXcvClosePort != NULL);
   EXPECT_TRUE(monitor2->pfnXcvClosePort(xcv_handle));
 
   // Test opening the port and running a print job.
   EXPECT_TRUE(monitor2->pfnOpenPort != NULL);
   EXPECT_TRUE(monitor2->pfnOpenPort(monitor_handle, NULL, &port_handle));
   EXPECT_TRUE(port_handle != NULL);
   EXPECT_TRUE(monitor2->pfnStartDocPort != NULL);
   EXPECT_TRUE(monitor2->pfnWritePort != NULL);
   EXPECT_TRUE(monitor2->pfnReadPort != NULL);
   EXPECT_TRUE(monitor2->pfnEndDocPort != NULL);
 
   // These functions should fail if we have not impersonated the user.
   EXPECT_FALSE(monitor2->pfnStartDocPort(
       port_handle, const_cast<wchar_t*>(L""), 0, 0, NULL));
   EXPECT_FALSE(monitor2->pfnWritePort(port_handle,
                                      buffer,
                                      kBufferSize,
                                      &bytes_processed));
-  EXPECT_EQ(0, bytes_processed);
+  EXPECT_EQ(0u, bytes_processed);
   EXPECT_FALSE(monitor2->pfnReadPort(port_handle,
                                      buffer,
                                      sizeof(buffer),
                                      &bytes_processed));
   EXPECT_EQ(0u, bytes_processed);
   EXPECT_FALSE(monitor2->pfnEndDocPort(port_handle));
 
   // Now impersonate so we can test the success case.
   ASSERT_TRUE(ImpersonateSelf(SecurityImpersonation));
   EXPECT_TRUE(monitor2->pfnStartDocPort(
@@ skipping 11 matching lines @@
   EXPECT_TRUE(monitor2->pfnEndDocPort(port_handle));
   RevertToSelf();
   EXPECT_TRUE(monitor2->pfnClosePort != NULL);
   EXPECT_TRUE(monitor2->pfnClosePort(port_handle));
   // Shutdown the port monitor.
   Monitor2Shutdown(monitor_handle);
 }
 
 }  // namespace cloud_print