Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
diff --git a/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc b/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
index 44b0f919a2fe0fb2e26ffa793a86eba86e1f37aa..644a88376a4a5059d2f2fd3b90fd84aeab1b8e68 100644
--- a/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
+++ b/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
@@ -63,8 +63,8 @@ class ProfileShortcutManagerTest : public testing::Test {
message_loop_.RunUntilIdle();
// Delete all profiles and ensure their shortcuts got removed.
- const int num_profiles = profile_info_cache_->GetNumberOfProfiles();
- for (int i = 0; i < num_profiles; ++i) {
+ const size_t num_profiles = profile_info_cache_->GetNumberOfProfiles();
+ for (size_t i = 0; i < num_profiles; ++i) {
const base::FilePath profile_path =
profile_info_cache_->GetPathOfProfileAtIndex(0);
base::string16 profile_name =
@@ -93,7 +93,7 @@ class ProfileShortcutManagerTest : public testing::Test {
}
void SetupDefaultProfileShortcut(const tracked_objects::Location& location) {
- ASSERT_EQ(0, profile_info_cache_->GetNumberOfProfiles())
+ ASSERT_EQ(0u, profile_info_cache_->GetNumberOfProfiles())
<< location.ToString();
ASSERT_FALSE(ProfileShortcutExistsAtDefaultPath(profile_1_name_))
<< location.ToString();

Powered by Google App Engine
This is Rietveld 408576698