clang/win: Let remaining chromium_code targets build with -Wextra.

chrome/installer/util/install_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <string>
 #include <utility>
 
 #include "base/base_paths.h"
@@ skipping 46 matching lines @@
 TEST_F(InstallUtilTest, ComposeCommandLine) {
   base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
 
   std::pair<std::wstring, std::wstring> params[] = {
     std::make_pair(std::wstring(L""), std::wstring(L"")),
     std::make_pair(std::wstring(L""), std::wstring(L"--do-something --silly")),
     std::make_pair(std::wstring(L"spam.exe"), std::wstring(L"")),
     std::make_pair(std::wstring(L"spam.exe"),
                    std::wstring(L"--do-something --silly")),
   };
-  for (int i = 0; i < arraysize(params); ++i) {
-    std::pair<std::wstring, std::wstring>& param = params[i];
+  for (std::pair<std::wstring, std::wstring>& param : params) {
     InstallUtil::ComposeCommandLine(param.first, param.second, &command_line);
     EXPECT_EQ(param.first, command_line.GetProgram().value());
     if (param.second.empty()) {
       EXPECT_TRUE(command_line.GetSwitches().empty());
     } else {
       EXPECT_EQ(2U, command_line.GetSwitches().size());
       EXPECT_TRUE(command_line.HasSwitch("do-something"));
       EXPECT_TRUE(command_line.HasSwitch("silly"));
     }
   }
 }
 
 TEST_F(InstallUtilTest, GetCurrentDate) {
   std::wstring date(InstallUtil::GetCurrentDate());
-  EXPECT_EQ(8, date.length());
+  EXPECT_EQ(8u, date.length());
   if (date.length() == 8) {
     // For an invalid date value, SystemTimeToFileTime will fail.
     // We use this to validate that we have a correct date string.
     SYSTEMTIME systime = {0};
     FILETIME ft = {0};
     // Just to make sure our assumption holds.
     EXPECT_FALSE(SystemTimeToFileTime(&systime, &ft));
     // Now fill in the values from our string.
     systime.wYear = _wtoi(date.substr(0, 4).c_str());
     systime.wMonth = _wtoi(date.substr(4, 2).c_str());
@@ skipping 381 matching lines @@
 #if defined(_WIN64)
   const int kOtherProgramFilesKey = base::DIR_PROGRAM_FILES;
   base::ScopedPathOverride other_program_files_override(kOtherProgramFilesKey);
   ASSERT_TRUE(PathService::Get(kOtherProgramFilesKey, &some_exe));
   some_exe = some_exe.AppendASCII("Company")
       .AppendASCII("Product")
       .AppendASCII("product.exe");
   EXPECT_TRUE(InstallUtil::IsPerUserInstall(some_exe));
 #endif  // defined(_WIN64)
 }