Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6125)

Unified Diff: chrome/installer/util/wmi_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/wmi_unittest.cc
diff --git a/chrome/installer/util/wmi_unittest.cc b/chrome/installer/util/wmi_unittest.cc
index 163c0415afbc5de592dbcaa9ad8ff07aa58e8644..798c5349469ef60082f238940478f2d8ebb1e313 100644
--- a/chrome/installer/util/wmi_unittest.cc
+++ b/chrome/installer/util/wmi_unittest.cc
@@ -14,7 +14,7 @@ TEST(WMITest, TestLocalConnectionSecurityBlanket) {
EXPECT_TRUE(WMI::CreateLocalConnection(true, &services));
ASSERT_TRUE(NULL != services);
ULONG refs = services->Release();
- EXPECT_EQ(refs, 0);
+ EXPECT_EQ(0u, refs);
}
TEST(WMITest, TestLocalConnectionNoSecurityBlanket) {
@@ -22,7 +22,7 @@ TEST(WMITest, TestLocalConnectionNoSecurityBlanket) {
EXPECT_TRUE(WMI::CreateLocalConnection(false, &services));
ASSERT_TRUE(NULL != services);
ULONG refs = services->Release();
- EXPECT_EQ(refs, 0);
+ EXPECT_EQ(0u, refs);
}
TEST(WMITest, TestCreateClassMethod) {
@@ -35,9 +35,9 @@ TEST(WMITest, TestCreateClassMethod) {
L"Rename", &class_method));
ASSERT_TRUE(NULL != class_method);
ULONG refs = class_method->Release();
- EXPECT_EQ(refs, 0);
+ EXPECT_EQ(0u, refs);
refs = wmi_services->Release();
- EXPECT_EQ(refs, 0);
+ EXPECT_EQ(0u, refs);
}
// Creates an instance of cmd which executes 'echo' and exits immediately.
« no previous file with comments | « chrome/installer/util/shell_util_unittest.cc ('k') | chrome/utility/importer/edge_database_reader_unittest_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698