Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: components/browser_watcher/endsession_watcher_window_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/browser_watcher/endsession_watcher_window_win.h" 5 #include "components/browser_watcher/endsession_watcher_window_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 void OnEndSessionMessage(UINT message, LPARAM lparam) { 23 void OnEndSessionMessage(UINT message, LPARAM lparam) {
24 ++num_callbacks_; 24 ++num_callbacks_;
25 last_message_ = message; 25 last_message_ = message;
26 last_lparam_ = lparam; 26 last_lparam_ = lparam;
27 } 27 }
28 28
29 size_t num_callbacks_; 29 size_t num_callbacks_;
30 UINT last_message_; 30 UINT last_message_;
31 UINT last_lparam_; 31 LPARAM last_lparam_;
32 }; 32 };
33 33
34 } // namespace browser_watcher 34 } // namespace browser_watcher
35 35
36 TEST_F(EndSessionWatcherWindowTest, NoCallbackOnDestruction) { 36 TEST_F(EndSessionWatcherWindowTest, NoCallbackOnDestruction) {
37 { 37 {
38 EndSessionWatcherWindow watcher_window( 38 EndSessionWatcherWindow watcher_window(
39 base::Bind(&EndSessionWatcherWindowTest::OnEndSessionMessage, 39 base::Bind(&EndSessionWatcherWindowTest::OnEndSessionMessage,
40 base::Unretained(this))); 40 base::Unretained(this)));
41 } 41 }
42 42
43 EXPECT_EQ(num_callbacks_, 0); 43 EXPECT_EQ(0u, num_callbacks_);
44 EXPECT_EQ(last_lparam_, 0); 44 EXPECT_EQ(0, last_lparam_);
45 } 45 }
46 46
47 TEST_F(EndSessionWatcherWindowTest, IssuesCallbackOnMessage) { 47 TEST_F(EndSessionWatcherWindowTest, IssuesCallbackOnMessage) {
48 EndSessionWatcherWindow watcher_window( 48 EndSessionWatcherWindow watcher_window(
49 base::Bind(&EndSessionWatcherWindowTest::OnEndSessionMessage, 49 base::Bind(&EndSessionWatcherWindowTest::OnEndSessionMessage,
50 base::Unretained(this))); 50 base::Unretained(this)));
51 51
52 ::SendMessage(watcher_window.window(), WM_QUERYENDSESSION, TRUE, 0xCAFEBABE); 52 ::SendMessage(watcher_window.window(), WM_QUERYENDSESSION, TRUE, 0xBEEF);
53 EXPECT_EQ(num_callbacks_, 1); 53 EXPECT_EQ(1u, num_callbacks_);
54 EXPECT_EQ(last_message_, WM_QUERYENDSESSION); 54 EXPECT_EQ(static_cast<DWORD>(WM_QUERYENDSESSION), last_message_);
55 EXPECT_EQ(last_lparam_, 0xCAFEBABE); 55 EXPECT_EQ(0xBEEF, last_lparam_);
56 56
57 ::SendMessage(watcher_window.window(), WM_ENDSESSION, TRUE, 0xCAFE); 57 ::SendMessage(watcher_window.window(), WM_ENDSESSION, TRUE, 0xCAFE);
58 EXPECT_EQ(num_callbacks_, 2); 58 EXPECT_EQ(2u, num_callbacks_);
59 EXPECT_EQ(last_message_, WM_ENDSESSION); 59 EXPECT_EQ(static_cast<UINT>(WM_ENDSESSION), last_message_);
60 EXPECT_EQ(last_lparam_, 0xCAFE); 60 EXPECT_EQ(0xCAFE, last_lparam_);
61 61
62 // Verify that other messages don't pass through. 62 // Verify that other messages don't pass through.
63 ::SendMessage(watcher_window.window(), WM_CLOSE, TRUE, 0xCAFE); 63 ::SendMessage(watcher_window.window(), WM_CLOSE, TRUE, 0xCAFE);
64 EXPECT_EQ(num_callbacks_, 2); 64 EXPECT_EQ(2u, num_callbacks_);
65 } 65 }
66 66
67 } // namespace browser_watcher 67 } // namespace browser_watcher
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698