chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc ('k') | chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc

index b15549ecf4722e48abffcdcb3c5fa92d10d0a9ea..8e2ce06586eb26c46acd5c6960391fe5836d9848 100644

--- a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc

@@ -42,7 +42,7 @@ TEST(BlacklistLoadAnalyzer, TestBlacklistBypass) {

// Check that the test dll appears in list.

module_names.clear();

EXPECT_TRUE(GetLoadedBlacklistedModules(&module_names));

- ASSERT_EQ(1, module_names.size());

+ ASSERT_EQ(1u, module_names.size());

EXPECT_STREQ(kTestDllName,

base::ToLowerASCII(

base::FilePath(module_names[0]).BaseName().value()).c_str());