sandbox/win/src/handle_closer_agent.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/handle_closer_agent.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/handle_closer_agent.cc

diff --git a/sandbox/win/src/handle_closer_agent.cc b/sandbox/win/src/handle_closer_agent.cc

index ae5c4d17a88979f86c395c33f585dfc22bc0b4dc..b26fb15fa74455d415993a3e186b04cffaddbc05 100644

--- a/sandbox/win/src/handle_closer_agent.cc

+++ b/sandbox/win/src/handle_closer_agent.cc

@@ -120,7 +120,7 @@ void HandleCloserAgent::InitializeHandlesToClose(bool* is_csrss_connected) {

DCHECK(reinterpret_cast<base::char16*>(entry) >= input);

DCHECK(reinterpret_cast<base::char16*>(entry) - input <

- sizeof(size_t) / sizeof(base::char16));

+ static_cast<ptrdiff_t>(sizeof(size_t) / sizeof(base::char16)));

}

// Clean up the memory we copied over.

« no previous file with comments | « rlz/win/lib/rlz_value_store_registry.cc ('k') | ui/base/dragdrop/os_exchange_data_win_unittest.cc » ('j') | no next file with comments »