Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
diff --git a/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc b/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
index f050c0d5dbd35d46998d2b20f3bb7bd184960555..cf878e8b32e5ea8d1ac8802d4fdd06ac61df0d8f 100644
--- a/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
+++ b/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
@@ -56,7 +56,7 @@ TEST_F(BinaryFeatureExtractorWinTest, UntrustedSignedBinary) {
ASSERT_EQ(1, signature_info.certificate_chain_size());
std::vector<scoped_refptr<net::X509Certificate> > certs;
ParseCertificateChain(signature_info.certificate_chain(0), &certs);
- ASSERT_EQ(2, certs.size());
+ ASSERT_EQ(2u, certs.size());
EXPECT_EQ("Joe's-Software-Emporium", certs[0]->subject().common_name);
EXPECT_EQ("Root Agency", certs[1]->subject().common_name);
@@ -73,7 +73,7 @@ TEST_F(BinaryFeatureExtractorWinTest, TrustedBinary) {
ASSERT_EQ(1, signature_info.certificate_chain_size());
std::vector<scoped_refptr<net::X509Certificate> > certs;
ParseCertificateChain(signature_info.certificate_chain(0), &certs);
- ASSERT_EQ(3, certs.size());
+ ASSERT_EQ(3u, certs.size());
EXPECT_EQ("Google Inc", certs[0]->subject().common_name);
EXPECT_EQ("VeriSign Class 3 Code Signing 2009-2 CA",
@@ -160,7 +160,7 @@ TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesWithDebugData) {
EXPECT_FALSE(pe_headers.has_optional_headers64());
EXPECT_NE(0, pe_headers.section_header_size());
EXPECT_TRUE(pe_headers.has_export_section_data());
- EXPECT_EQ(1U, pe_headers.debug_data_size());
+ EXPECT_EQ(1, pe_headers.debug_data_size());
}
TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesWithoutExports) {
@@ -179,7 +179,7 @@ TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesWithoutExports) {
EXPECT_FALSE(pe_headers.has_optional_headers64());
EXPECT_NE(0, pe_headers.section_header_size());
EXPECT_FALSE(pe_headers.has_export_section_data());
- EXPECT_EQ(1U, pe_headers.debug_data_size());
+ EXPECT_EQ(1, pe_headers.debug_data_size());
}
TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesUntrustedSigned) {
« no previous file with comments | « chrome/common/importer/firefox_importer_utils_win.cc ('k') | chrome/installer/gcapi/gcapi_reactivation_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698