chrome/browser/web_applications/update_shortcut_worker_win.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/update_shortcut_worker_win.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc ('k') | chrome/browser/web_applications/web_app_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_applications/update_shortcut_worker_win.cc

diff --git a/chrome/browser/web_applications/update_shortcut_worker_win.cc b/chrome/browser/web_applications/update_shortcut_worker_win.cc

index 09b0051642dc9aeeb064e809efe7eae35602f242..26810eb22b851b30b247a6ddfe667539b1bf4c1e 100644

--- a/chrome/browser/web_applications/update_shortcut_worker_win.cc

+++ b/chrome/browser/web_applications/update_shortcut_worker_win.cc

@@ -154,7 +154,7 @@ void UpdateShortcutWorker::CheckExistingShortcuts() {

}

};

- for (int i = 0; i < arraysize(locations); ++i) {

+ for (size_t i = 0; i < arraysize(locations); ++i) {

base::FilePath path;

if (!PathService::Get(locations[i].location_id, &path)) {

NOTREACHED();