Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: components/storage_monitor/storage_monitor_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/storage_monitor/storage_monitor_win_unittest.cc
diff --git a/components/storage_monitor/storage_monitor_win_unittest.cc b/components/storage_monitor/storage_monitor_win_unittest.cc
index 84eb51e553ad78aaff54ae531526d9b9a8b8ea9e..f146cfc7b4e749314fd73aaf686b32ba70a5b31f 100644
--- a/components/storage_monitor/storage_monitor_win_unittest.cc
+++ b/components/storage_monitor/storage_monitor_win_unittest.cc
@@ -295,7 +295,7 @@ TEST_F(StorageMonitorWinTest, DevicesAttached) {
TEST_F(StorageMonitorWinTest, PathMountDevices) {
PreAttachDevices();
- int init_storages = monitor_->GetAllAvailableStorages().size();
+ size_t init_storages = monitor_->GetAllAvailableStorages().size();
volume_mount_watcher_->AddDeviceForTesting(
base::FilePath(FILE_PATH_LITERAL("F:\\mount1")),
@@ -475,7 +475,7 @@ TEST_F(StorageMonitorWinTest, DeviceInfoForPath) {
EXPECT_EQ(info.device_id(), device_info.device_id());
EXPECT_EQ(info.GetDisplayName(false), device_info.GetDisplayName(false));
EXPECT_EQ(info.location(), device_info.location());
- EXPECT_EQ(1000000, info.total_size_in_bytes());
+ EXPECT_EQ(1000000u, info.total_size_in_bytes());
// A fixed device.
base::FilePath fixed_device(L"N:\\");
« no previous file with comments | « components/policy/core/common/registry_dict_win_unittest.cc ('k') | device/bluetooth/bluetooth_adapter_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698