clang/win: Let remaining chromium_code targets build with -Wextra.

chrome/browser/autocomplete/in_memory_url_index_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <fstream>
 
 #include "base/auto_reset.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 1013 matching lines @@
   // transition types are what we expect.  We don't bother checking
   // the timestamps because it's too much trouble.  (The timestamps go
   // through a transformation in InMemoryURLIndexTest::SetUp().  We
   // assume that if the count and transitions show up with the right
   // information, we're getting the right information from the history
   // database file.)
   HistoryInfoMap::const_iterator entry = history_info_map.find(1);
   ASSERT_TRUE(entry != history_info_map.end());
   {
     const VisitInfoVector& visits = entry->second.visits;
     EXPECT_EQ(3u, visits.size());

[Lei Zhang, 2015/12/09 22:17:15]

ASSERT_EQ(), ditto below, sigh.

[Nico, 2015/12/09 22:22:35]

Done.

-    EXPECT_EQ(0u, visits[0].second);
-    EXPECT_EQ(1u, visits[1].second);
-    EXPECT_EQ(0u, visits[2].second);
+    EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[0].second);

[Lei Zhang, 2015/12/09 22:17:15]

Maybe just use the enum values?

[Nico, 2015/12/09 22:22:35]

I figured this uses literal ints to also test that the enum values don't change,
so I kept this.

+    EXPECT_EQ(static_cast<ui::PageTransition>(1u), visits[1].second);
+    EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[2].second);
   }
 
   // Ditto but for URL with id 35.
   entry = history_info_map.find(35);
   ASSERT_TRUE(entry != history_info_map.end());
   {
     const VisitInfoVector& visits = entry->second.visits;
     EXPECT_EQ(2u, visits.size());
-    EXPECT_EQ(1u, visits[0].second);
-    EXPECT_EQ(1u, visits[1].second);
+    EXPECT_EQ(static_cast<ui::PageTransition>(1u), visits[0].second);
+    EXPECT_EQ(static_cast<ui::PageTransition>(1u), visits[1].second);
   }
 
   // The URL with id 32 has many visits listed in the database, but we
   // should only read the most recent 10 (which are all transition type 0).
   entry = history_info_map.find(32);
   ASSERT_TRUE(entry != history_info_map.end());
   {
     const VisitInfoVector& visits = entry->second.visits;
     EXPECT_EQ(10u, visits.size());
     for (size_t i = 0; i < visits.size(); ++i)
-      EXPECT_EQ(0u, visits[i].second);
+      EXPECT_EQ(static_cast<ui::PageTransition>(0u), visits[i].second);
   }
 }
 
 TEST_F(InMemoryURLIndexTest, CacheSaveRestore) {
   base::ScopedTempDir temp_directory;
   ASSERT_TRUE(temp_directory.CreateUniqueTempDir());
   set_history_dir(temp_directory.path());
 
   URLIndexPrivateData& private_data(*GetPrivateData());
 
@@ skipping 264 matching lines @@
   ASSERT_TRUE(GetCacheFilePath(&full_file_path));
   std::vector<base::FilePath::StringType> actual_parts;
   full_file_path.GetComponents(&actual_parts);
   ASSERT_EQ(expected_parts.size(), actual_parts.size());
   size_t count = expected_parts.size();
   for (size_t i = 0; i < count; ++i)
     EXPECT_EQ(expected_parts[i], actual_parts[i]);
   // Must clear the history_dir_ to satisfy the dtor's DCHECK.
   set_history_dir(base::FilePath());
 }