Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4988)

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/install_util_unittest.cc ('k') | chrome/installer/util/logging_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/installer_state_unittest.cc
diff --git a/chrome/installer/util/installer_state_unittest.cc b/chrome/installer/util/installer_state_unittest.cc
index b40817071d6fd6cf228f965bda2ef6e43071a495..ac3ea11c146e9655914f7a63fe677deb9448a0d8 100644
--- a/chrome/installer/util/installer_state_unittest.cc
+++ b/chrome/installer/util/installer_state_unittest.cc
@@ -543,7 +543,7 @@ TEST_F(InstallerStateTest, RemoveOldVersionDirs) {
};
// Create the version directories.
- for (int i = 0; i < arraysize(version_dirs); i++) {
+ for (size_t i = 0; i < arraysize(version_dirs); i++) {
base::CreateDirectory(version_dirs[i]);
EXPECT_TRUE(base::PathExists(version_dirs[i]));
}
@@ -564,7 +564,7 @@ TEST_F(InstallerStateTest, RemoveOldVersionDirs) {
{ installer_state.target_path().Append(installer::kChromeNewExe),
new_chrome_exe_version },
};
- for (int i = 0; i < arraysize(targets); ++i) {
+ for (size_t i = 0; i < arraysize(targets); ++i) {
ASSERT_TRUE(upgrade_test::GenerateSpecificPEFileVersion(
exe_path, targets[i].target_file, targets[i].target_version));
}
« no previous file with comments | « chrome/installer/util/install_util_unittest.cc ('k') | chrome/installer/util/logging_installer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698