chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc ('k') | chrome/browser/shell_integration_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc

index 5a354143dffd2151b30fcd5b63fab5dedb3b0a19..bf00f7d84982dd353523ebcb06fa54f982c24df6 100644

--- a/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc

@@ -99,7 +99,7 @@ class PlatformStateStoreWinTest : public ::testing::Test {

ASSERT_EQ(ERROR_SUCCESS,

key.ReadValue(base::UTF8ToUTF16(kProfileName_).c_str(),

&buffer[0], &data_size, &data_type));

- EXPECT_EQ(REG_BINARY, data_type);

+ EXPECT_EQ(static_cast<DWORD>(REG_BINARY), data_type);

ASSERT_EQ(kTestDataSize_, data_size);

EXPECT_EQ(std::string(&buffer[0], data_size),

std::string(&kTestData_[0], kTestDataSize_));