chrome_elf/elf_imports_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/elf_imports_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome_elf/blacklist/test/blacklist_test.cc ('k') | cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome_elf/elf_imports_unittest.cc

diff --git a/chrome_elf/elf_imports_unittest.cc b/chrome_elf/elf_imports_unittest.cc

index 87a1f596707238023671c83593cd08e5eb7d58da..806ed790a043a34dbd00d9b4783174241e984880 100644

--- a/chrome_elf/elf_imports_unittest.cc

+++ b/chrome_elf/elf_imports_unittest.cc

@@ -91,8 +91,8 @@ TEST_F(ELFImportsTest, ChromeElfSanityCheck) {

// Make sure all of ELF's imports are in the valid imports list.

for (const std::string& import : elf_imports) {

bool match = false;

- for (int i = 0; i < arraysize(kValidFilePatterns); ++i) {

- if (base::MatchPattern(import, kValidFilePatterns[i])) {

+ for (const char* kValidFilePattern : kValidFilePatterns) {

+ if (base::MatchPattern(import, kValidFilePattern)) {

match = true;

break;

}