Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chrome/installer/util/shell_util_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/set_reg_value_work_item_unittest.cc ('k') | chrome/installer/util/wmi_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util_unittest.cc
diff --git a/chrome/installer/util/shell_util_unittest.cc b/chrome/installer/util/shell_util_unittest.cc
index e581064826853c096693abb81123bc8b085fd00e..9b6308d5184ec1e6dae324ccad7026090ad2cbf9 100644
--- a/chrome/installer/util/shell_util_unittest.cc
+++ b/chrome/installer/util/shell_util_unittest.cc
@@ -1023,7 +1023,7 @@ TEST(ShellUtilTest, GetUserSpecificRegistrySuffix) {
base::string16 suffix;
ASSERT_TRUE(ShellUtil::GetUserSpecificRegistrySuffix(&suffix));
ASSERT_TRUE(base::StartsWith(suffix, L".", base::CompareCase::SENSITIVE));
- ASSERT_EQ(27, suffix.length());
+ ASSERT_EQ(27u, suffix.length());
ASSERT_TRUE(base::ContainsOnlyChars(suffix.substr(1),
L"ABCDEFGHIJKLMNOPQRSTUVWXYZ234567"));
}
@@ -1048,7 +1048,7 @@ TEST(ShellUtilTest, ByteArrayToBase32) {
L"MZXW6YTB", L"MZXW6YTBOI"};
// Run the tests, with one more letter in the input every pass.
- for (int i = 0; i < arraysize(expected); ++i) {
+ for (size_t i = 0; i < arraysize(expected); ++i) {
ASSERT_EQ(expected[i],
ShellUtil::ByteArrayToBase32(test_array, i));
}
« no previous file with comments | « chrome/installer/util/set_reg_value_work_item_unittest.cc ('k') | chrome/installer/util/wmi_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698