Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyze r.h" 5 #include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyze r.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 24 matching lines...) Expand all
35 for (; module_iter != module_names.end(); ++module_iter) { 35 for (; module_iter != module_names.end(); ++module_iter) {
36 LOG(ERROR) << "Found blacklisted module: " << *module_iter; 36 LOG(ERROR) << "Found blacklisted module: " << *module_iter;
37 } 37 }
38 38
39 // Add test dll to blacklist 39 // Add test dll to blacklist
40 blacklist::AddDllToBlacklist(kTestDllName); 40 blacklist::AddDllToBlacklist(kTestDllName);
41 41
42 // Check that the test dll appears in list. 42 // Check that the test dll appears in list.
43 module_names.clear(); 43 module_names.clear();
44 EXPECT_TRUE(GetLoadedBlacklistedModules(&module_names)); 44 EXPECT_TRUE(GetLoadedBlacklistedModules(&module_names));
45 ASSERT_EQ(1, module_names.size()); 45 ASSERT_EQ(1u, module_names.size());
46 EXPECT_STREQ(kTestDllName, 46 EXPECT_STREQ(kTestDllName,
47 base::ToLowerASCII( 47 base::ToLowerASCII(
48 base::FilePath(module_names[0]).BaseName().value()).c_str()); 48 base::FilePath(module_names[0]).BaseName().value()).c_str());
49 } 49 }
50 50
51 } // namespace safe_browsing 51 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698