Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: remoting/host/setup/daemon_controller_delegate_win.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/local_input_monitor_win.cc ('k') | rlz/win/lib/machine_deal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/setup/daemon_controller_delegate_win.cc
diff --git a/remoting/host/setup/daemon_controller_delegate_win.cc b/remoting/host/setup/daemon_controller_delegate_win.cc
index 70267946e134ffe0c1b612929b90055cfebcc9e0..58c6bd560ba189b78ad93b99a64cb8af162fd678 100644
--- a/remoting/host/setup/daemon_controller_delegate_win.cc
+++ b/remoting/host/setup/daemon_controller_delegate_win.cc
@@ -179,8 +179,7 @@ bool WriteConfig(const std::string& content) {
// Extract the unprivileged fields from the configuration.
base::DictionaryValue unprivileged_config_dict;
- for (int i = 0; i < arraysize(kUnprivilegedConfigKeys); ++i) {
- const char* key = kUnprivilegedConfigKeys[i];
+ for (const char* key : kUnprivilegedConfigKeys) {
base::string16 value;
if (config_dict->GetString(key, &value)) {
unprivileged_config_dict.SetString(key, value);
@@ -382,7 +381,7 @@ void DaemonControllerDelegateWin::UpdateConfig(
scoped_ptr<base::DictionaryValue> config,
const DaemonController::CompletionCallback& done) {
// Check for bad keys.
- for (int i = 0; i < arraysize(kReadonlyKeys); ++i) {
+ for (size_t i = 0; i < arraysize(kReadonlyKeys); ++i) {
if (config->HasKey(kReadonlyKeys[i])) {
LOG(ERROR) << "Cannot update config: '" << kReadonlyKeys[i]
<< "' is read only.";
« no previous file with comments | « remoting/host/local_input_monitor_win.cc ('k') | rlz/win/lib/machine_deal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698