rlz/win/lib/machine_deal.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rlz/win/lib/machine_deal.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rlz/win/lib/machine_deal.cc

diff --git a/rlz/win/lib/machine_deal.cc b/rlz/win/lib/machine_deal.cc

index afb935fe61631343d12ddd816132c4eb2e4e2b45..5b5d007885f41b8b87b7628b321e54ba128bf1da 100644

--- a/rlz/win/lib/machine_deal.cc

+++ b/rlz/win/lib/machine_deal.cc

@@ -57,7 +57,7 @@ bool IsGoodDccChar(char ch) {

// reasonable size. It also assumes that normalized_dcc is at least

// kMaxDccLength+1 long.

void NormalizeDcc(const char* raw_dcc, char* normalized_dcc) {

- int index = 0;

+ size_t index = 0;

for (; raw_dcc[index] != 0 && index < rlz_lib::kMaxDccLength; ++index) {

char current = raw_dcc[index];

if (IsGoodDccChar(current)) {

« no previous file with comments | « remoting/host/setup/daemon_controller_delegate_win.cc ('k') | rlz/win/lib/process_info.cc » ('j') | no next file with comments »