Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/browser_watcher/exit_funnel_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/exit_funnel_win_unittest.cc
diff --git a/components/browser_watcher/exit_funnel_win_unittest.cc b/components/browser_watcher/exit_funnel_win_unittest.cc
index b43b273650aae83efe090c5e8d07b52599e4c17a..d45a291bb94b367265e7b4cac4ad361d8c0cddda 100644
--- a/components/browser_watcher/exit_funnel_win_unittest.cc
+++ b/components/browser_watcher/exit_funnel_win_unittest.cc
@@ -37,7 +37,7 @@ class ExitFunnelWinTest : public testing::Test {
base::string16 GetEventSubkey() {
// There should be a single subkey named after this process' pid.
base::win::RegistryKeyIterator it(HKEY_CURRENT_USER, kRegistryPath);
- EXPECT_EQ(1, it.SubkeyCount());
+ EXPECT_EQ(1u, it.SubkeyCount());
unsigned pid = 0;
base::StringToUint(it.Name(), &pid);
@@ -53,7 +53,7 @@ class ExitFunnelWinTest : public testing::Test {
base::win::RegKey key(HKEY_CURRENT_USER, key_name.c_str(), KEY_READ);
EXPECT_TRUE(key.Valid());
- EXPECT_EQ(2, key.GetValueCount());
+ EXPECT_EQ(2u, key.GetValueCount());
EventMap events;
for (size_t i = 0; i < key.GetValueCount(); ++i) {
@@ -86,7 +86,7 @@ TEST_F(ExitFunnelWinTest, RecordSingleEvent) {
EventMap events = ReadEvents();
- ASSERT_EQ(events.size(), 2);
+ ASSERT_EQ(2u, events.size());
ASSERT_TRUE(events.find(L"One") != events.end());
ASSERT_TRUE(events.find(L"Two") != events.end());
}
@@ -103,7 +103,7 @@ TEST_F(ExitFunnelWinTest, RecordsEventTimes) {
ASSERT_TRUE(funnel.RecordEvent(L"Two"));
EventMap events = ReadEvents();
- ASSERT_EQ(events.size(), 2);
+ ASSERT_EQ(2u, events.size());
base::TimeDelta one = base::TimeDelta::FromInternalValue(events[L"One"]);
base::TimeDelta two = base::TimeDelta::FromInternalValue(events[L"Two"]);

Powered by Google App Engine
This is Rietveld 408576698