Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/installer/util/delete_reg_value_work_item_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <windows.h> 5 #include <windows.h>
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/test/test_reg_util_win.h" 9 #include "base/test/test_reg_util_win.h"
10 #include "base/win/registry.h" 10 #include "base/win/registry.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 DWORD read_dword; 85 DWORD read_dword;
86 EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(kNameStr, &read_str)); 86 EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(kNameStr, &read_str));
87 EXPECT_EQ(ERROR_SUCCESS, key.ReadValueDW(kNameDword, &read_dword)); 87 EXPECT_EQ(ERROR_SUCCESS, key.ReadValueDW(kNameDword, &read_dword));
88 EXPECT_EQ(read_str, data_str); 88 EXPECT_EQ(read_str, data_str);
89 EXPECT_EQ(read_dword, data_dword); 89 EXPECT_EQ(read_dword, data_dword);
90 90
91 // Verify empty value. 91 // Verify empty value.
92 DWORD type = 0; 92 DWORD type = 0;
93 DWORD size = 0; 93 DWORD size = 0;
94 EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(kNameEmpty, NULL, &size, &type)); 94 EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(kNameEmpty, NULL, &size, &type));
95 EXPECT_EQ(REG_SZ, type); 95 EXPECT_EQ(static_cast<DWORD>(REG_SZ), type);
96 EXPECT_EQ(0, size); 96 EXPECT_EQ(0u, size);
97 } 97 }
98 98
99 // Try deleting a value that doesn't exist. 99 // Try deleting a value that doesn't exist.
100 TEST_F(DeleteRegValueWorkItemTest, DeleteNonExistentValue) { 100 TEST_F(DeleteRegValueWorkItemTest, DeleteNonExistentValue) {
101 RegKey key; 101 RegKey key;
102 ASSERT_EQ(ERROR_SUCCESS, 102 ASSERT_EQ(ERROR_SUCCESS,
103 key.Create(HKEY_CURRENT_USER, kTestKey, KEY_READ | KEY_WRITE)); 103 key.Create(HKEY_CURRENT_USER, kTestKey, KEY_READ | KEY_WRITE));
104 EXPECT_FALSE(key.HasValue(kNameStr)); 104 EXPECT_FALSE(key.HasValue(kNameStr));
105 EXPECT_FALSE(key.HasValue(kNameDword)); 105 EXPECT_FALSE(key.HasValue(kNameDword));
106 106
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 143
144 EXPECT_EQ(ERROR_FILE_NOT_FOUND, 144 EXPECT_EQ(ERROR_FILE_NOT_FOUND,
145 key.Open(HKEY_CURRENT_USER, kTestKey, KEY_READ)); 145 key.Open(HKEY_CURRENT_USER, kTestKey, KEY_READ));
146 146
147 work_item1->Rollback(); 147 work_item1->Rollback();
148 work_item2->Rollback(); 148 work_item2->Rollback();
149 149
150 EXPECT_EQ(ERROR_FILE_NOT_FOUND, 150 EXPECT_EQ(ERROR_FILE_NOT_FOUND,
151 key.Open(HKEY_CURRENT_USER, kTestKey, KEY_READ)); 151 key.Open(HKEY_CURRENT_USER, kTestKey, KEY_READ));
152 } 152 }
OLDNEW
« no previous file with comments | « chrome/installer/util/delete_after_reboot_helper_unittest.cc ('k') | chrome/installer/util/google_update_settings_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698