Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4715)

Unified Diff: chrome/installer/util/delete_after_reboot_helper_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/delete_after_reboot_helper_unittest.cc
diff --git a/chrome/installer/util/delete_after_reboot_helper_unittest.cc b/chrome/installer/util/delete_after_reboot_helper_unittest.cc
index 867106e81808d3f643778e8e7f202a78d98c8932..1dd84332658638bc395942202395bfa08870454a 100644
--- a/chrome/installer/util/delete_after_reboot_helper_unittest.cc
+++ b/chrome/installer/util/delete_after_reboot_helper_unittest.cc
@@ -111,7 +111,7 @@ TEST_F(DeleteAfterRebootHelperTest, TestStringListToMultiSZConversions) {
{ L"deletes", L"foo\0\0bar\0\0bizz\0\0", 16 * sizeof(wchar_t), 3 },
};
- for (int i = 0; i < arraysize(tests); i++) {
+ for (size_t i = 0; i < arraysize(tests); i++) {
std::vector<PendingMove> string_list;
EXPECT_TRUE(SUCCEEDED(
MultiSZBytesToStringArray(reinterpret_cast<const char*>(tests[i].str),
@@ -132,7 +132,7 @@ TEST_F(DeleteAfterRebootHelperTest, TestStringListToMultiSZConversions) {
{L"malformed", reinterpret_cast<const wchar_t*>("oddnumb\0\0"), 9, 1},
};
- for (int i = 0; i < arraysize(failures); i++) {
+ for (size_t i = 0; i < arraysize(failures); i++) {
std::vector<PendingMove> string_list;
EXPECT_FALSE(SUCCEEDED(MultiSZBytesToStringArray(
reinterpret_cast<const char*>(failures[i].str),
@@ -171,7 +171,7 @@ TEST_F(DeleteAfterRebootHelperTest, TestFileDeleteScheduleAndUnschedule) {
// Check that each of the deletes we expect are there in order.
base::FilePath expected_paths[] =
{ temp_file_, temp_subdir_file_, temp_subdir_, temp_dir_ };
- for (int i = 0; i < arraysize(expected_paths); ++i) {
+ for (size_t i = 0; i < arraysize(expected_paths); ++i) {
EXPECT_FALSE(iter == pending_moves.end());
if (iter != pending_moves.end()) {
base::FilePath short_path_name(GetShortPathName(expected_paths[i]));
@@ -225,7 +225,7 @@ TEST_F(DeleteAfterRebootHelperTest, TestFileDeleteSchedulingWithActualDeletes) {
// Check that each of the deletes we expect are there in order.
base::FilePath expected_paths[] =
{ temp_file_, temp_subdir_file_, temp_subdir_, temp_dir_ };
- for (int i = 0; i < arraysize(expected_paths); ++i) {
+ for (size_t i = 0; i < arraysize(expected_paths); ++i) {
EXPECT_FALSE(iter == pending_moves.end());
if (iter != pending_moves.end()) {
base::FilePath short_path_name(GetShortPathName(expected_paths[i]));
« no previous file with comments | « chrome/installer/gcapi/gcapi_reactivation_test.cc ('k') | chrome/installer/util/delete_reg_value_work_item_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698