Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/installer/util/self_cleaning_temp_dir_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/self_cleaning_temp_dir_unittest.cc
diff --git a/chrome/installer/util/self_cleaning_temp_dir_unittest.cc b/chrome/installer/util/self_cleaning_temp_dir_unittest.cc
index 64445e697ad7522cbb29f65fce37e7092b6f7d2a..8f3df0ec26cc605f3c00d9cf951ec3b5f9f5b7df 100644
--- a/chrome/installer/util/self_cleaning_temp_dir_unittest.cc
+++ b/chrome/installer/util/self_cleaning_temp_dir_unittest.cc
@@ -28,7 +28,7 @@ std::string GetRandomFilename() {
// Hexify the value.
std::string result(base::HexEncode(&data[0], arraysize(data)));
- EXPECT_EQ(8, result.size());
+ EXPECT_EQ(8u, result.size());
// Replace the first digit with the letter 'R' (for "random", get it?).
result[0] = 'R';
@@ -159,7 +159,7 @@ TEST_F(SelfCleaningTempDirTest, LeaveUsedOnDestroy) {
EXPECT_EQ(parent_temp_dir.Append(L"Three"), temp_dir.path());
EXPECT_TRUE(base::DirectoryExists(temp_dir.path()));
// Drop a file somewhere.
- EXPECT_EQ(arraysize(kHiHon) - 1,
+ EXPECT_EQ(static_cast<int>(arraysize(kHiHon) - 1),
base::WriteFile(parent_temp_dir.AppendASCII(GetRandomFilename()),
kHiHon, arraysize(kHiHon) - 1));
}
« no previous file with comments | « chrome/installer/util/master_preferences_unittest.cc ('k') | chrome/installer/util/set_reg_value_work_item_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698