components/crash/content/app/crash_keys_win_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/crash_keys_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_watcher/watcher_metrics_provider_win_unittest.cc ('k') | components/policy/core/common/registry_dict_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/crash_keys_win_unittest.cc

diff --git a/components/crash/content/app/crash_keys_win_unittest.cc b/components/crash/content/app/crash_keys_win_unittest.cc

index f1a645e32058b06f55cb8be1b7e3e3c3edf31a62..197066ff7b651eedc8ceda5d3a8ba49c65fc6311 100644

--- a/components/crash/content/app/crash_keys_win_unittest.cc

+++ b/components/crash/content/app/crash_keys_win_unittest.cc

@@ -129,15 +129,15 @@ TEST_F(CrashKeysWinTest, OfficialLikeKeys) {

// We expect 7 fixed keys and a "freeboard" of 256 keys for dynamic entries.

EXPECT_EQ(256U + 7U, info->count);

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"ver", L"1.2.3.4"));

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"prod", L"SomeProdName"));

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"plat", L"Win32"));

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"ptype", L"made_up_type"));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"ver", L"1.2.3.4"));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"prod", L"SomeProdName"));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"plat", L"Win32"));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"ptype", L"made_up_type"));

std::wstring pid_str(base::StringPrintf(L"%d", ::GetCurrentProcessId()));

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"pid", pid_str.c_str()));

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"channel", L"-devm"));

- EXPECT_EQ(1, CountKeyValueOccurences(info, L"profile-type", L"temporary"));

- EXPECT_EQ(256, CountKeyValueOccurences(info, L"unspecified-crash-key", L""));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"pid", pid_str.c_str()));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"channel", L"-devm"));

+ EXPECT_EQ(1u, CountKeyValueOccurences(info, L"profile-type", L"temporary"));

+ EXPECT_EQ(256u, CountKeyValueOccurences(info, L"unspecified-crash-key", L""));

}

} // namespace breakpad