clang/win: Let remaining chromium_code targets build with -Wextra.

chrome_elf/elf_imports_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <windows.h>
 
 #include <algorithm>
 #include <vector>
 
@@ skipping 73 matching lines @@
 #endif
 #if defined(ADDRESS_SANITIZER) && defined(COMPONENT_BUILD)
     "clang_rt.asan_dynamic-i386.dll",
 #endif
     "ADVAPI32.dll"
   };
 
   // Make sure all of ELF's imports are in the valid imports list.
   for (const std::string& import : elf_imports) {
     bool match = false;
-    for (int i = 0; i < arraysize(kValidFilePatterns); ++i) {
-      if (base::MatchPattern(import, kValidFilePatterns[i])) {
+    for (const char* kValidFilePattern : kValidFilePatterns) {
+      if (base::MatchPattern(import, kValidFilePattern)) {
         match = true;
         break;
       }
     }
     ASSERT_TRUE(match) << "Illegal import in chrome_elf.dll: " << import;
   }
 }
 #endif  // NDEBUG
 
 TEST_F(ELFImportsTest, ChromeExeSanityCheck) {
   std::vector<std::string> exe_imports;
 
   base::FilePath exe;
   ASSERT_TRUE(PathService::Get(base::DIR_EXE, &exe));
   exe = exe.Append(L"chrome.exe");
   GetImports(exe, &exe_imports);
 
   // Check that chrome.exe has imports.
   ASSERT_LT(0u, exe_imports.size()) << "Ensure the chrome_elf_unittests "
     "target was built, instead of chrome_elf_unittests.exe";
 
   // Chrome.exe's first import must be ELF.
   EXPECT_EQ("chrome_elf.dll", exe_imports[0]) <<
       "Illegal import order in chrome.exe (ensure the chrome_elf_unittest "
       "target was built, instead of just chrome_elf_unittests.exe)";
 }
 
 }  // namespace