Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6571)

Unified Diff: chrome/installer/util/install_util_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/install_util_unittest.cc
diff --git a/chrome/installer/util/install_util_unittest.cc b/chrome/installer/util/install_util_unittest.cc
index 8d0dcc7532c4b625d7d7e38e24eaf78e1ba29797..40467f53df7d8482fa22139c7a3ccd543d86d4cd 100644
--- a/chrome/installer/util/install_util_unittest.cc
+++ b/chrome/installer/util/install_util_unittest.cc
@@ -64,8 +64,7 @@ TEST_F(InstallUtilTest, ComposeCommandLine) {
std::make_pair(std::wstring(L"spam.exe"),
std::wstring(L"--do-something --silly")),
};
- for (int i = 0; i < arraysize(params); ++i) {
- std::pair<std::wstring, std::wstring>& param = params[i];
+ for (std::pair<std::wstring, std::wstring>& param : params) {
InstallUtil::ComposeCommandLine(param.first, param.second, &command_line);
EXPECT_EQ(param.first, command_line.GetProgram().value());
if (param.second.empty()) {
@@ -80,7 +79,7 @@ TEST_F(InstallUtilTest, ComposeCommandLine) {
TEST_F(InstallUtilTest, GetCurrentDate) {
std::wstring date(InstallUtil::GetCurrentDate());
- EXPECT_EQ(8, date.length());
+ EXPECT_EQ(8u, date.length());
if (date.length() == 8) {
// For an invalid date value, SystemTimeToFileTime will fail.
// We use this to validate that we have a correct date string.
« no previous file with comments | « chrome/installer/util/google_update_settings_unittest.cc ('k') | chrome/installer/util/installer_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698