chrome/installer/util/delete_reg_value_work_item_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/delete_reg_value_work_item_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/delete_after_reboot_helper_unittest.cc ('k') | chrome/installer/util/google_update_settings_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/delete_reg_value_work_item_unittest.cc

diff --git a/chrome/installer/util/delete_reg_value_work_item_unittest.cc b/chrome/installer/util/delete_reg_value_work_item_unittest.cc

index 9a508aec4b23e00e6eb2745134b6b141e4295448..0c1f11e7c0da546ead677b61f4c9bf9fb5548505 100644

--- a/chrome/installer/util/delete_reg_value_work_item_unittest.cc

+++ b/chrome/installer/util/delete_reg_value_work_item_unittest.cc

@@ -92,8 +92,8 @@ TEST_F(DeleteRegValueWorkItemTest, DeleteExistingValue) {

DWORD type = 0;

DWORD size = 0;

EXPECT_EQ(ERROR_SUCCESS, key.ReadValue(kNameEmpty, NULL, &size, &type));

- EXPECT_EQ(REG_SZ, type);

- EXPECT_EQ(0, size);

+ EXPECT_EQ(static_cast<DWORD>(REG_SZ), type);

+ EXPECT_EQ(0u, size);

}

// Try deleting a value that doesn't exist.