Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: device/bluetooth/bluetooth_device_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/bind.h" 6 #include "base/bind.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/sequenced_task_runner.h" 8 #include "base/sequenced_task_runner.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 protected: 79 protected:
80 scoped_ptr<BluetoothDeviceWin> device_; 80 scoped_ptr<BluetoothDeviceWin> device_;
81 scoped_ptr<BluetoothTaskManagerWin::DeviceState> device_state_; 81 scoped_ptr<BluetoothTaskManagerWin::DeviceState> device_state_;
82 scoped_ptr<BluetoothDeviceWin> empty_device_; 82 scoped_ptr<BluetoothDeviceWin> empty_device_;
83 scoped_ptr<BluetoothTaskManagerWin::DeviceState> empty_device_state_; 83 scoped_ptr<BluetoothTaskManagerWin::DeviceState> empty_device_state_;
84 }; 84 };
85 85
86 TEST_F(BluetoothDeviceWinTest, GetUUIDs) { 86 TEST_F(BluetoothDeviceWinTest, GetUUIDs) {
87 BluetoothDevice::UUIDList uuids = device_->GetUUIDs(); 87 BluetoothDevice::UUIDList uuids = device_->GetUUIDs();
88 88
89 EXPECT_EQ(2, uuids.size()); 89 EXPECT_EQ(2u, uuids.size());
90 EXPECT_EQ(kTestAudioSdpUuid, uuids[0]); 90 EXPECT_EQ(kTestAudioSdpUuid, uuids[0]);
91 EXPECT_EQ(kTestVideoSdpUuid, uuids[1]); 91 EXPECT_EQ(kTestVideoSdpUuid, uuids[1]);
92 92
93 uuids = empty_device_->GetUUIDs(); 93 uuids = empty_device_->GetUUIDs();
94 EXPECT_EQ(0, uuids.size()); 94 EXPECT_EQ(0u, uuids.size());
95 } 95 }
96 96
97 TEST_F(BluetoothDeviceWinTest, IsEqual) { 97 TEST_F(BluetoothDeviceWinTest, IsEqual) {
98 EXPECT_TRUE(device_->IsEqual(*device_state_)); 98 EXPECT_TRUE(device_->IsEqual(*device_state_));
99 EXPECT_FALSE(device_->IsEqual(*empty_device_state_)); 99 EXPECT_FALSE(device_->IsEqual(*empty_device_state_));
100 EXPECT_FALSE(empty_device_->IsEqual(*device_state_)); 100 EXPECT_FALSE(empty_device_->IsEqual(*device_state_));
101 EXPECT_TRUE(empty_device_->IsEqual(*empty_device_state_)); 101 EXPECT_TRUE(empty_device_->IsEqual(*empty_device_state_));
102 } 102 }
103 103
104 } // namespace device 104 } // namespace device
OLDNEW
« no previous file with comments | « device/bluetooth/bluetooth_adapter_win_unittest.cc ('k') | device/bluetooth/bluetooth_service_record_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698