Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: chrome/common/importer/firefox_importer_utils_win.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/importer/firefox_importer_utils_win.cc
diff --git a/chrome/common/importer/firefox_importer_utils_win.cc b/chrome/common/importer/firefox_importer_utils_win.cc
index 7cfbc508e46a6e8954b3fbd936fba472547ec36f..47486d11c7b740a6f60a4800e9885cae6f521a7e 100644
--- a/chrome/common/importer/firefox_importer_utils_win.cc
+++ b/chrome/common/importer/firefox_importer_utils_win.cc
@@ -32,9 +32,8 @@ int GetCurrentFirefoxMajorVersionFromRegistry() {
// When installing Firefox with admin account, the product keys will be
// written under HKLM\Mozilla. Otherwise it the keys will be written under
// HKCU\Mozilla.
- for (int i = 0; i < arraysize(kFireFoxRegistryPaths); ++i) {
- base::win::RegKey reg_key(kFireFoxRegistryPaths[i], kFirefoxPath,
- KEY_READ);
+ for (const HKEY kFireFoxRegistryPath : kFireFoxRegistryPaths) {
+ base::win::RegKey reg_key(kFireFoxRegistryPath, kFirefoxPath, KEY_READ);
LONG result = reg_key.ReadValue(kCurrentVersion, ver_buffer,
&ver_buffer_length, NULL);
« no previous file with comments | « chrome/child/pdf_child_init.cc ('k') | chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698