Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome_elf/blacklist/test/blacklist_test.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/edge_database_reader_unittest_win.cc ('k') | chrome_elf/elf_imports_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/blacklist/test/blacklist_test.cc
diff --git a/chrome_elf/blacklist/test/blacklist_test.cc b/chrome_elf/blacklist/test/blacklist_test.cc
index 09d6a730c2bc08115fca332329a6dcf08dfc0ef6..44f7aaf4239daca2846fba742d947d47e45ae78a 100644
--- a/chrome_elf/blacklist/test/blacklist_test.cc
+++ b/chrome_elf/blacklist/test/blacklist_test.cc
@@ -65,7 +65,7 @@ class BlacklistTest : public testing::Test {
base::FilePath current_dir;
ASSERT_TRUE(PathService::Get(base::DIR_EXE, &current_dir));
- for (int i = 0; i < arraysize(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
// Ensure that the dll has not been loaded both by inspecting the handle
// returned by LoadLibrary and by looking for an environment variable that
// is set when the DLL's entry point is called.
@@ -233,7 +233,7 @@ TEST_F(BlacklistTest, LoadBlacklistedLibrary) {
EXPECT_EQ(num_initially_blocked_, num_blocked_dlls);
// Add all DLLs to the blacklist then check they are blocked.
- for (int i = 0; i < arraysize(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
EXPECT_TRUE(TestDll_AddDllToBlacklist(test_data[i].dll_name));
}
CheckBlacklistedDllsNotLoaded();
@@ -254,7 +254,7 @@ TEST_F(BlacklistTest, AddDllsFromRegistryToBlacklist) {
HKEY_CURRENT_USER,
blacklist::kRegistryFinchListPath,
KEY_QUERY_VALUE | KEY_SET_VALUE);
- for (int i = 0; i < arraysize(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
finch_blacklist_registry_key.WriteValue(test_data[i].dll_name,
test_data[i].dll_name);
}
« no previous file with comments | « chrome/utility/importer/edge_database_reader_unittest_win.cc ('k') | chrome_elf/elf_imports_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698